-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a basic implementation of Recheck Interval into the health check service. #10610
base: master
Are you sure you want to change the base?
Conversation
Please let me know if I made the PR correctly, or if any changes are needed. |
Hi @kevinpollet , I'm encountering issues with failing tests due to the interface change from I'd appreciate your input on how best to address this. One option is to modify the interface to eliminate the need for the getter method, perhaps by having SetStatus return the original status before modification. Your suggestions on ensuring compatibility with other services implementing this interface would be invaluable. Thank you. |
Another possibility is to consider expanding the tests to include this new field, which I believe will become necessary regardless. Your guidance on this matter would be greatly appreciated, @kevinpollet. |
c5d2c2a
to
74a7bf6
Compare
Hi @kevinpollet , |
Hi @kevinpollet, |
Signed-off-by: sswastik02 <40518186+sswastik02@users.noreply.github.com>
Signed-off-by: sswastik02 <40518186+sswastik02@users.noreply.github.com>
Signed-off-by: sswastik02 <40518186+sswastik02@users.noreply.github.com>
Run `make generate-crd` with Recheck feature Signed-off-by: sswastik02 <40518186+sswastik02@users.noreply.github.com>
Hi @kevinpollet, |
Thank you @ldez. @kevinpollet Please do let me know if any changes are necessary on this PR |
What does this PR do?
This PR Addresses the issue where the interval for health checks remains static even when a service starts failing. This lack of adaptability may result in unreliable detection of issues on time. By implementing a recheck interval, we ensure that the health status of a service is re-evaluated at regular intervals, especially when it fails, thereby improving the accuracy and responsiveness of issue detection.
Motivation
Aims to improve the reliability and responsiveness of issue detection, particularly in scenarios where services may intermittently fail or experience fluctuations in health status.
More
Additional Notes
Utilization of providers is yet to be implemented. Future work will focus on integrating this functionality to further enhance the flexibility and extensibility of the health check system.
Fixes #6550