Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use typing.NamedTuple instead of collections.namedtuple #3330

Merged
merged 1 commit into from
Jun 7, 2024
Merged

use typing.NamedTuple instead of collections.namedtuple #3330

merged 1 commit into from
Jun 7, 2024
+13 −9

Conversation

mslynch
Copy link
Contributor

@mslynch mslynch commented Sep 29, 2023

Enhances typing for RequestStartLine and ResponseStartLine.

HTTPServerRequest may set its method/uri/version properties from RequestStartLine. On Pyright, since these properties' types are unknown, those HTTPServerRequest properties may also become unknown.

@bdarnell
Copy link
Member

bdarnell commented Jun 7, 2024

Thanks!

@bdarnell bdarnell merged commit 816ef01 into tornadoweb:master Jun 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mslynch @bdarnell