Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): replace history to ViewService.history #6972

Merged
merged 1 commit into from
May 22, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented May 17, 2024

upstream: #6966

Copy link

graphite-app bot commented May 17, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

JimmFly commented May 17, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.47%. Comparing base (3b8345e) to head (609766d).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6972      +/-   ##
==========================================
- Coverage   67.54%   67.47%   -0.07%     
==========================================
  Files         584      584              
  Lines       28381    28381              
  Branches     2590     2589       -1     
==========================================
- Hits        19170    19151      -19     
- Misses       8940     8959      +19     
  Partials      271      271              
Flag Coverage Δ
server-test 78.32% <ø> (-0.09%) ⬇️
unittest 39.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly force-pushed the jimmfly/0517/refactor branch 2 times, most recently from c5bb74c to be181ce Compare May 20, 2024 04:49
@JimmFly JimmFly requested a review from EYHN May 20, 2024 04:49
@JimmFly JimmFly force-pushed the jimmfly/0517/refactor branch 2 times, most recently from 764082c to 4635f1e Compare May 20, 2024 06:46
@JimmFly JimmFly marked this pull request as ready for review May 20, 2024 06:50
@JimmFly JimmFly changed the title refactor(core): replace history to workbench.activeView.history refactor(core): replace history to ViewService.history May 20, 2024
@JimmFly JimmFly force-pushed the jimmfly/0517/refactor branch 2 times, most recently from 99197a1 to 3e2e9ce Compare May 20, 2024 08:26
@JimmFly JimmFly force-pushed the jimmfly/0517/refactor branch 2 times, most recently from 3b0fde7 to e6db76a Compare May 20, 2024 09:05
@github-actions github-actions bot added the mod:i18n Related to i18n label May 20, 2024
@JimmFly JimmFly requested a review from EYHN May 20, 2024 09:13
Copy link

graphite-app bot commented May 20, 2024

Merge activity

EYHN pushed a commit that referenced this pull request May 20, 2024
JimmFly added a commit that referenced this pull request May 21, 2024
@JimmFly JimmFly force-pushed the jimmfly/0517/refactor branch 2 times, most recently from 86d0ce1 to 43f55da Compare May 21, 2024 07:44
@JimmFly JimmFly requested a review from pengx17 May 21, 2024 10:57
@graphite-app graphite-app bot merged commit 609766d into canary May 22, 2024
33 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0517/refactor branch May 22, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

4 participants