Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

touch: add Simplified Chinese Translation #12786

Merged
merged 7 commits into from
May 21, 2024
Merged

touch: add Simplified Chinese Translation #12786

merged 7 commits into from
May 21, 2024

Conversation

Smart-SangGe
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@CLAassistant
Copy link

CLAassistant commented May 14, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the translation Translate pages from one language to another. label May 14, 2024
einverne
einverne previously requested changes May 14, 2024
View reviewed changes
Copy link
Member

@einverne einverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Smart-SangGe thank you for the new page, I left a suggestion.

pages.zh/common/touch.md Outdated
# touch

> 创建文件并设置访问/修改时间。
> 更多信息：<https://manned.org/man/freebsd-13.1/touch>。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> 更多信息：<https://manned.org/man/freebsd-13.1/touch>。
> 更多信息：<https://manned.org/man/freebsd-13.1/touch>.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion. I have made the changes according to your recommendation.

jimmychang851129
jimmychang851129 reviewed May 15, 2024
View reviewed changes
pages.zh/common/touch.md Outdated

`touch -c -t {{YYYYMMDDHHMM.SS}} {{路径/到/文件1 路径/到/文件2 ...}}`

- 将文件时间设置为另一个文件的时间，如果文件不存在则不创建：
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, the current description is not clear that the command will set 文件1, 文件2 file time to emacs filetime.

I suggest

  1. replace emacs to 文件3
  2. change the description to 將文件時間設置為文件3的時間

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion. I have made the changes according to your recommendation.

@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages.zh/common/touch.md is outdated, based on the command contents itself.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

1 similar comment
@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages.zh/common/touch.md is outdated, based on the command contents itself.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

sebastiaanspeck
sebastiaanspeck requested changes May 18, 2024
View reviewed changes
pages.zh/common/touch.md Outdated

- 创建指定的文件：

`touch 路径/到/文件名1 路径/到/文件名2 ...`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`touch 路径/到/文件名1 路径/到/文件名2 ...`
`touch {{路径/到/文件名1 路径/到/文件名2 ...}}`

pages.zh/common/touch.md Outdated

- 将文件的访问(a)或修改时间(m)设置为当前时间，如果文件不存在则不创建(-c)：

`touch -c -a|m 路径/到/文件1 路径/到/文件2 ...`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`touch -c -a|m 路径/到/文件1 路径/到/文件2 ...`
`touch -c -a|m {{路径/到/文件1 路径/到/文件2 ...}}`

pages.zh/common/touch.md Outdated

- 将文件时间(-t)设置为指定值，如果文件不存在则不创建(-c)：

`touch -c -t YYYYMMDDHHMM.SS 路径/到/文件名1 路径/到/文件名2 ...`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`touch -c -t YYYYMMDDHHMM.SS 路径/到/文件名1 路径/到/文件名2 ...`
`touch -c -t YYYYMMDDHHMM.SS {{路径/到/文件名1 路径/到/文件名2 ...}}`

pages.zh/common/touch.md Outdated

- 将文件时间设置为另一文件(-r,即文件3)的时间，如果文件不存在则不创建(-c)：

`touch -c -r 路径/到/文件3 路径/到/文件名1 路径/到/文件名2 ...`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`touch -c -r 路径/到/文件3 路径/到/文件名1 路径/到/文件名2 ...`
`touch -c -r {{路径/到/文件3}} {{路径/到/文件名1 路径/到/文件名2 ...}}`

@spageektti spageektti requested a review from einverne May 21, 2024 16:04
@spageektti spageektti dismissed einverne’s stale review May 21, 2024 16:06

suggested changes have been made

spageektti
spageektti approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@spageektti spageektti merged commit f00b073 into tldr-pages:main May 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmychang851129 jimmychang851129 jimmychang851129 left review comments

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@spageektti spageektti spageektti approved these changes

@einverne einverne einverne left review comments

Assignees
No one assigned
Labels
translation Translate pages from one language to another.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Smart-SangGe @CLAassistant @tldr-bot @einverne @sebastiaanspeck @jimmychang851129 @spageektti