Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lstopo: add page #12785

Merged
merged 2 commits into from
May 14, 2024
Merged

lstopo: add page #12785

merged 2 commits into from
May 14, 2024

Conversation

cyqsimon
Copy link
Collaborator

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): 2.10.0

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label May 14, 2024
gutjuri
gutjuri approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the title :P

pages/common/lstopo.md Outdated Show resolved Hide resolved
@cyqsimon @gutjuri
lstopo: fix page title
03b1c4b 
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
spageektti
spageektti approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @cyqsimon and thanks for your contribution. I checked the examples both locally and with the man page. LGTM after the little change I suggested.

@spageektti spageektti closed this May 14, 2024
@spageektti spageektti reopened this May 14, 2024
@spageektti
Copy link
Collaborator

Closed and reopened to restart CLA test.

@spageektti spageektti merged commit 9095c83 into tldr-pages:main May 14, 2024
7 checks passed
@Managor
Copy link
Collaborator

Managor commented May 15, 2024

Amazing timing guys. I was just about to make a page for lstopo

@cyqsimon cyqsimon deleted the lstopo branch May 15, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spageektti spageektti spageektti approved these changes

@gutjuri gutjuri gutjuri approved these changes

@acuteenvy acuteenvy acuteenvy approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cyqsimon @spageektti @Managor @gutjuri @acuteenvy