Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctop: add page #12683

Merged
merged 6 commits into from
May 27, 2024
Merged

ctop: add page #12683

merged 6 commits into from
May 27, 2024

Conversation

saliaku
Copy link
Contributor

@saliaku saliaku commented Apr 26, 2024 •
edited by spageektti

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@saliaku saliaku requested a review from cyqsimon as a code owner April 26, 2024 19:53
@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Apr 26, 2024
@kbdharun kbdharun changed the title ctop on tldr ctop: add page Apr 27, 2024
CleanMachine1
CleanMachine1 reviewed Apr 27, 2024
View reviewed changes
pages/linux/ctop.md Outdated Show resolved Hide resolved
CleanMachine1
CleanMachine1 reviewed Apr 28, 2024
View reviewed changes
pages/linux/ctop.md Outdated Show resolved Hide resolved
pages/linux/ctop.md Outdated Show resolved Hide resolved
pages/linux/ctop.md Outdated Show resolved Hide resolved
pages/linux/ctop.md Outdated Show resolved Hide resolved
@saliaku @CleanMachine1
Update pages/linux/ctop.md
631e56e 
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
@spageektti
Copy link
Collaborator

Hello @saliaku. Thank you for your contribution. I remind you about this PR.

@saliaku @CleanMachine1
Apply suggestions from code review
5fac942 
done sorry for the delay

Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
spageektti
spageektti approved these changes May 18, 2024
View reviewed changes
Copy link
Collaborator

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution again. I made some suggestions - I added short option mnemonics.

pages/linux/ctop.md Outdated Show resolved Hide resolved
pages/linux/ctop.md Outdated Show resolved Hide resolved
pages/linux/ctop.md Outdated Show resolved Hide resolved
pages/linux/ctop.md Outdated Show resolved Hide resolved
@spageektti spageektti requested a review from kbdharun May 27, 2024 17:46
kbdharun
kbdharun approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@spageektti spageektti merged commit fbeade0 into tldr-pages:main May 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CleanMachine1 CleanMachine1 CleanMachine1 left review comments

@kbdharun kbdharun kbdharun approved these changes

@spageektti spageektti spageektti approved these changes

@cyqsimon cyqsimon Awaiting requested review from cyqsimon cyqsimon is a code owner

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saliaku @spageektti @kbdharun @CleanMachine1