yt-dlp: update page #12580

thrila · 2024-03-30T01:18:23Z

The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
The page(s) have at most 8 examples.
The page description(s) have links to documentation or a homepage.
The page(s) follow the content guidelines.
The PR title conforms to the recommended templates.
Version of the command being documented (if known):

thrila · 2024-03-30T01:20:56Z

@kbdharun please confirm

pages/common/yt-dlp.md

thrila · 2024-03-30T02:20:41Z

Thanks for the correction

pages/common/yt-dlp.md

Magrid0

Looks good to me

pages/common/yt-dlp.md

CleanMachine1 · 2024-04-02T00:54:35Z

You did not make any changes following my comments, and then proceeded to close them, saying they have been resolved.

Please actually respond to them appropriately.

CleanMachine1

Please do not approve before actually reading and commenting on my original feedback.

thrila · 2024-04-02T01:01:35Z

my apologies started using github mobile seems im yet to fully understand it , still i thought the change you made was changing the placeholder url to the keyword url

CleanMachine1 · 2024-04-12T23:48:24Z

Do you plan on changing anything suggested, or should we close this PR?

thrila · 2024-04-13T00:16:31Z

Do you plan on changing anything suggested, or should we close this PR?

yeah lemme do it now kinda forgot

removed url e.g youtube.com and added a placeholder

feat: merge previous branch

thrila · 2024-04-13T01:29:47Z

Do you plan on changing anything suggested, or should we close this PR?

Hi finished do you mind checking?

CleanMachine1 · 2024-04-13T14:16:28Z

That commit has nothing in it, did you not push your changes?

thrila · 2024-04-17T00:15:48Z

That commit has nothing in it, did you not push your changes?

Seems i didnt my bad haven't really contributed to a project before Thanks for the patience

pages/common/yt-dlp.md

thrila · 2024-05-05T23:12:27Z

Any more corrections?

vitorhcl · 2024-05-06T02:56:08Z

I think he is just merging the branch instead of commit the changes.

@thrila if you are on GitHub Mobile, you meed to click on the comments and then click om the "Commit" button.

thrila · 2024-05-06T08:22:53Z

I am on mobile thanks for the tip
Still there's one thing that confuses me
As you can see from the last stream of commits the placeholder was removed and a example URL was placed I don't know if this is something he did for all of them how do I check? Other than that I actually started with an example URL and some dudes said a place holder was better when I made a PR

vitorhcl · 2024-05-07T21:50:56Z

Still there's one thing that confuses me
As you can see from the last stream of commits the placeholder was removed and a example URL was placed

I saw the last commits and it looks like it's the opposite, you replaced the example URLs with the generic placeholder text "url".

I don't know if this is something he did for all of them how do I check?

Well, the current state is replacing some examples URLs with the "url" placeholder.

Anyways, you can see the changes that would be applied if thisnPR was merged clicking on the first bar below the PR description that has green and red numbers (the quantity of modified lines).

Green = addition, red = removal.

Other than that I actually started with an example URL and some dudes said a place holder was better when I made a PR

Are you talking about #12580 (comment)? I don't know if @kbdharun thinks it is a good idea or if that was just a suggestion for improving the page consistency.

In my opinion, in this case, example URLs are more user-friendly.

kbdharun · 2024-05-09T09:52:07Z

Are you talking about #12580 (comment)? I don't know if @kbdharun thinks it is a good idea or if that was just a suggestion for improving the page consistency.

Agreed, having example URLs seems much better. I wasn't clear in my previous review comment, what I meant is since one example was updated to the URL I suggested updating it throughout the page or reverting the link in the specific line (in this case, reverting seems like the best course of action).

sebastiaanspeck · 2024-05-24T02:45:52Z

Hi @thrila, we are sending you a friendly nudge this PR still has unresolved comments. Could you please make the suggested changes?

thrila · 2024-05-26T01:22:23Z

Hi @thrila, we are sending you a friendly nudge this PR still has unresolved comments. Could you please make the suggested changes?

yeah will do it right now

yt-dlp: merge changes from yt-dlp branch

thrila · 2024-05-27T08:04:14Z

done !! please check to make sure it's the format we want

kbdharun

Thanks for your contribution. I have some suggestions for this page. After this the PR is GTG.

pages/common/yt-dlp.md

sebastiaanspeck · 2024-05-27T11:46:28Z

pages/common/yt-dlp.md

@@ -27,12 +27,12 @@

 - Download all playlists of YouTube channel/user keeping each playlist in separate directory:

-`yt-dlp -o "{{%(uploader)s/%(playlist)s/%(playlist_index)s - %(title)s.%(ext)s}}" "{{https://www.youtube.com/user/TheLinuxFoundation/playlists}}"`
+`yt-dlp -o "{{%(uploader)s/%(playlist)s/%(playlist_index)s - %(title)s.%(ext)s}}" "{{https://www.youtube.com/watch?v=oHg5SJYRHA0}}"`


IMO this example URL does not match the description above

Hi, would you please not resolve a comment without any explanation why or not changing anything.

thrila · 2024-05-27T11:50:29Z

Thanks for your contribution. I have some suggestions for this page. After this the PR is GTG.

Well ok I'll make the changes

Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

thrila · 2024-05-27T16:26:01Z

can some check to connfirm that the changes were indeed applied?

kbdharun

LGTM, as the other maintainers say these links must be updated to align with their example description.

kbdharun · 2024-05-27T16:47:31Z

pages/common/yt-dlp.md


-`yt-dlp -o "{{%(uploader)s/%(playlist)s/%(playlist_index)s - %(title)s.%(ext)s}}" "{{https://www.youtube.com/user/TheLinuxFoundation/playlists}}"`
+`yt-dlp -o "{{%(uploader)s/%(playlist)s/%(playlist_index)s - %(title)s.%(ext)s}}" "{{https://www.youtube.com/watch?v=oHg5SJYRHA0}}"`


Suggested change

`yt-dlp -o "{{%(uploader)s/%(playlist)s/%(playlist_index)s - %(title)s.%(ext)s}}" "{{https://www.youtube.com/watch?v=oHg5SJYRHA0}}"`

`yt-dlp -o "{{%(uploader)s/%(playlist)s/%(playlist_index)s - %(title)s.%(ext)s}}" "{{https://www.youtube.com/user/TheLinuxFoundation/playlists}}"`

kbdharun · 2024-05-27T16:47:46Z

pages/common/yt-dlp.md


-`yt-dlp -P "{{C:/MyVideos}}" -o "{{%(series)s/%(season_number)s - %(season)s/%(episode_number)s - %(episode)s.%(ext)s}}" "{{https://videomore.ru/kino_v_detalayah/5_sezon/367617}}"`
+`yt-dlp -P "{{path/to/directory}}" -o "{{%(series)s/%(season_number)s - %(season)s/%(episode_number)s - %(episode)s.%(ext)s}}" "{{https://www.youtube.com/watch?v=oHg5SJYRHA0}}"`


Suggested change

`yt-dlp -P "{{path/to/directory}}" -o "{{%(series)s/%(season_number)s - %(season)s/%(episode_number)s - %(episode)s.%(ext)s}}" "{{https://www.youtube.com/watch?v=oHg5SJYRHA0}}"`

`yt-dlp -P "{{path/to/directory}}" -o "{{%(series)s/%(season_number)s - %(season)s/%(episode_number)s - %(episode)s.%(ext)s}}" "{{https://videomore.ru/kino_v_detalayah/5_sezon/367617}}"`

Is this URL valid because I got 403?

Is this URL valid because I got 403?

Oh, I didn't check for it (just reverted the change), do you have any suggestions for a new one?

Is this URL valid because I got 403?

Oh, I didn't check for it (just reverted the change), do you have any suggestions for a new one?

No, because I don't understand this example fully.

Maybe a playlist like https://youtube.com/playlist?list=PLqE7PUanPIFTs1Zy1Lz270nUHhtZcx66e&si=VTWFdggY2cbLCLsP?

too much changed

thrila and others added 3 commits October 5, 2023 12:58

yt-dlp: refactor ytdlp page in youtube-dl format

6e469ba

yt-dlp: remove incidental extra space

a37f211

Merge branch 'tldr-pages:main' into main

2590579

github-actions bot added the page edit Changes to an existing page(s). label Mar 30, 2024

CleanMachine1 requested changes Mar 30, 2024

View reviewed changes

pages/common/yt-dlp.md Outdated Show resolved Hide resolved

pages/common/yt-dlp.md Outdated Show resolved Hide resolved

pages/common/yt-dlp.md Outdated Show resolved Hide resolved

pages/common/yt-dlp.md Outdated Show resolved Hide resolved

fazlearefin reviewed Mar 30, 2024

View reviewed changes

pages/common/yt-dlp.md Outdated Show resolved Hide resolved

Magrid0 previously approved these changes Mar 30, 2024

View reviewed changes

kbdharun changed the title ~~chore: add page for yt-dlp~~ yt-dlp: update page Mar 30, 2024

kbdharun reviewed Mar 30, 2024

View reviewed changes

pages/common/yt-dlp.md Outdated Show resolved Hide resolved

CleanMachine1 requested changes Apr 2, 2024

View reviewed changes

thrila and others added 5 commits April 13, 2024 01:29

feat: removed url and added placeholder

2f3be91

removed url e.g youtube.com and added a placeholder

Merge branch 'main' into yt-dlp

6b25c63

chore: change placeholder path

0b85d8c

Merge branch 'yt-dlp' of github.com:thrila/tldr into yt-dlp

b59ddc8

feat: merge previous branch

Merge branch 'tldr-pages:main' into main

845c4ff

thrila closed this Apr 13, 2024

thrila reopened this Apr 13, 2024

Merge branch 'tldr-pages:main' into main

52be391

vitorhcl requested changes Apr 23, 2024

View reviewed changes

pages/common/yt-dlp.md Outdated Show resolved Hide resolved

Merge branch 'main' into main

b92be93

Merge branch 'main' into main

b9fd88e

Merge branch 'main' into main

38d7320

thrila requested a review from spageektti as a code owner May 26, 2024 01:25

yt-dlp: edit file with suggestions

07a0557

sebastiaanspeck mentioned this pull request May 26, 2024

yt-dlp: edit document #12839

Closed

5 tasks

thrila and others added 2 commits May 27, 2024 08:58

Merge branch 'yt-dlp'

1042a44

yt-dlp: merge changes from yt-dlp branch

Merge branch 'tldr-pages:main' into main

6192988

kbdharun requested review from CleanMachine1 and Magrid0 May 27, 2024 08:05

kbdharun reviewed May 27, 2024

View reviewed changes

sebastiaanspeck reviewed May 27, 2024

View reviewed changes

thrila and others added 7 commits May 27, 2024 17:21

Update pages/common/yt-dlp.md

ddb8a24

Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

Update pages/common/yt-dlp.md

4ea2b36

Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

Update pages/common/yt-dlp.md

31366a1

Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

Update pages/common/yt-dlp.md

4268b31

Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

Update pages/common/yt-dlp.md

166eb90

Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

Update pages/common/yt-dlp.md

0188dd2

Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

Merge branch 'main' into main

bcf4bf6

kbdharun approved these changes May 27, 2024

View reviewed changes

CleanMachine1 removed their request for review May 28, 2024 20:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

yt-dlp: update page #12580

yt-dlp: update page #12580

thrila commented Mar 30, 2024

thrila commented Mar 30, 2024

thrila commented Mar 30, 2024

Magrid0 left a comment

CleanMachine1 commented Apr 2, 2024

CleanMachine1 left a comment

thrila commented Apr 2, 2024

CleanMachine1 commented Apr 12, 2024

thrila commented Apr 13, 2024

thrila commented Apr 13, 2024

CleanMachine1 commented Apr 13, 2024

thrila commented Apr 17, 2024

thrila commented May 5, 2024

vitorhcl commented May 6, 2024

thrila commented May 6, 2024

vitorhcl commented May 7, 2024

kbdharun commented May 9, 2024 •

edited

sebastiaanspeck commented May 24, 2024

thrila commented May 26, 2024

thrila commented May 27, 2024

kbdharun left a comment •

edited

sebastiaanspeck May 27, 2024

sebastiaanspeck May 28, 2024

thrila commented May 27, 2024

thrila commented May 27, 2024

kbdharun left a comment

kbdharun May 27, 2024

kbdharun May 27, 2024

spageektti May 27, 2024

kbdharun May 27, 2024

spageektti May 27, 2024

sebastiaanspeck May 28, 2024


		`yt-dlp -o "{{%(uploader)s/%(playlist)s/%(playlist_index)s - %(title)s.%(ext)s}}" "{{https://www.youtube.com/user/TheLinuxFoundation/playlists}}"`
		`yt-dlp -o "{{%(uploader)s/%(playlist)s/%(playlist_index)s - %(title)s.%(ext)s}}" "{{https://www.youtube.com/watch?v=oHg5SJYRHA0}}"`


		`yt-dlp -P "{{C:/MyVideos}}" -o "{{%(series)s/%(season_number)s - %(season)s/%(episode_number)s - %(episode)s.%(ext)s}}" "{{https://videomore.ru/kino_v_detalayah/5_sezon/367617}}"`
		`yt-dlp -P "{{path/to/directory}}" -o "{{%(series)s/%(season_number)s - %(season)s/%(episode_number)s - %(episode)s.%(ext)s}}" "{{https://www.youtube.com/watch?v=oHg5SJYRHA0}}"`

yt-dlp: update page #12580

Are you sure you want to change the base?

yt-dlp: update page #12580

Conversation

thrila commented Mar 30, 2024

thrila commented Mar 30, 2024

thrila commented Mar 30, 2024

Magrid0 left a comment

Choose a reason for hiding this comment

CleanMachine1 commented Apr 2, 2024

CleanMachine1 left a comment

Choose a reason for hiding this comment

thrila commented Apr 2, 2024

CleanMachine1 commented Apr 12, 2024

thrila commented Apr 13, 2024

thrila commented Apr 13, 2024

CleanMachine1 commented Apr 13, 2024

thrila commented Apr 17, 2024

thrila commented May 5, 2024

vitorhcl commented May 6, 2024

thrila commented May 6, 2024

vitorhcl commented May 7, 2024

kbdharun commented May 9, 2024 • edited

sebastiaanspeck commented May 24, 2024

thrila commented May 26, 2024

thrila commented May 27, 2024

kbdharun left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thrila commented May 27, 2024

thrila commented May 27, 2024

kbdharun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kbdharun commented May 9, 2024 •

edited

kbdharun left a comment •

edited