Metronome implementation #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good so far! Please let me know when the feature is complete, and I can integrate it into UTSU. |
…o feature/metronome
…/javafx/17-ea+8 # Conflicts: # pom.xml
# Conflicts: # src/main/java/com/utsusynth/utsu/engine/Engine.java
atoko
changed the title
atoko
force-pushed
the
feature/metronome
branch
from
8e5350c
to
d9b930c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds code on
Engine.javato create a metronome. The metronome "attaches" itself to the current media player, taking in as arguments the MediaPlayer, the file path of the wave file to play and an Observable BooleanProperty that represents whether or not the metronome should be beeping.It registers itself to the parent MediaPlayer onDispose and calls dispose on itself before calling the original onDispose method on the parent.