This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
feat: reduce image size by 100MB using multi-stage dockerbuild, introduce using a user #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlongman
changed the title
pickywicky
reviewed
Oct 27, 2021
| @@ -41,9 +41,9 @@ then | |||
| export CONFIG="/etc/pyhydroquebec/pyhydroquebec.yaml" | |||
| fi | |||
|
|
|||
| if [ "$PYHQ_OUTPUT" == "MQTT" ] | |||
There was a problem hiding this comment.
definitely didn't know this previously but for the bourne shell, sh:
== operator is not supported in POSIX sh
https://github.com/koalaman/shellcheck/wiki/SC2039#testing-equality
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a multi-stage build - reduces size from ~160MB by ~100MB down to 60MB.
--userinstallation which puts the installation into$HOME/.local.Use a user in the final container - best practices, security.
/root/.localto/home/appuser/.localnote, I've only tested
docker run --rm -it -ePYHQ_USER -ePYHQ_PASSWORDfrom the cli as I don't have a mqtt setup atm.