-
-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃摑 Update package section #781
base: master
Are you sure you want to change the base?
Conversation
馃摑 Docs preview for commit 78ff949 at: https://a1c57cae.typertiangolo.pages.dev |
馃摑 Docs preview for commit 82b21f9 at: https://44cb1ad4.typertiangolo.pages.dev |
馃摑 Docs preview for commit 19b5663 at: https://1d7e4ec1.typertiangolo.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution @kinuax! I revised the changes while running through the docs on my system as well, and I can confirm that almost all of your edits accurately reflect the current output and behaviour of poetry
and typer
. Thanks for going through all of this so carefully!
The only thing that is different on my system and with Typer 0.12.3, are the installed libraries. Could you double check how this looks on your end with the latest Typer? I know there's been some changes in the recent Typer versions, so it's likely that this has changed since you made this PR originally.
馃摑 Docs preview for commit ae06c64 at: https://bf13e94e.typertiangolo.pages.dev |
ae06c64
to
f9d3546
Compare
馃摑 Docs preview for commit f9d3546 at: https://73a1f39f.typertiangolo.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me and should be ready for merge after a final review by Tiangolo!
I have followed the package section (Building a Package) and I would propose to update:
-current Poetry dependencies and behavior
-current Typer dependencies and behavior
-current pip behavior
-recent
typer
command changes-example user rick harmonization