-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batch - is_empty() #1125
base: master
Are you sure you want to change the base?
batch - is_empty() #1125
Conversation
The linting failed. Plz make sure to run Also additionally, make sure to run |
@DarkTechPirate Plz make sure to perform the replacements (as specified in the description of the issue #1108) that you did in the batch.py also in the test files and in all other places where the usage of For example, if you look into the output of one of the failed checks on Github here (by scrolling down to the "short test summary info"), you can see all the test files where the error Afterward you can run the tests locally before pushing. Try to run at least the reduced test suite with |
@DarkTechPirate Make sure to catch all |
@dantp-ai okay i got it , will update it and let you know . |
@DarkTechPirate I wanted to touch base regarding the status of the PR. If you have any questions or need further clarification on the review comments, please feel free to reach out. I'm here to help, and happy to discuss any aspects of the changes in more detail or assist you in implementing them if needed. |
@dantp-ai I guess we should take it over |
poe format
poe lint
andpoe type-check
poe test
(or a subset of them with
poe test-reduced
) ,and they passpoe doc-build