feat: remove/fix rubocop todos

* fix `Layout/ArgumentAlignment`

* fix `Layout/EmptyLineBetweenDefs`

* fix `Layout/ExtraSpacing`

* fix `Layout/FirstArrayElementIndentation`

* fix `Layout/MultilineMethodCallBraceLayout`

* fix `Layout/MultilineMethodCallIndentation`

* fix `Layout/SpaceAroundOperators`

* fix `Layout/SpaceBeforeBlockBraces`

* fix `Lint/EmptyWhen`

* fix `Lint/LiteralAsCondition`

* fix `Lint/UnusedBlockArgument`

* fix `Style/BlockDelimiters`

* fix `Style/CaseLikeIf`

* fix `Style/ClassEqualityComparison`

* fix `Style/ConditionalAssignment`

* fix `Style/EmptyMethod`

* fix `Style/IfInsideElse`

* fix `Style/MultilineTernaryOperator`

* fix `Style/OrAssignment`

* fix `Style/RedundantConditional`

* fix `Style/RedundantRegexpEscape`

* fix `Style/StringConcatenation`

* fix `Style/StringLiterals`

* fix `Style/SymbolArray`

* fix `Style/PerlBackrefs`

* fix `Naming/AccessorMethodName`

* fix `Naming/MemoizedInstanceVariableName`

* fix `Style/NegatedIfElseCondition`

* fix `Style/NestedTernaryOperator`

* fix `Lint/FloatComparison`

* fix `Lint/DuplicateBranch`

* fix `Lint/UnusedMethodArgument`

* fix `Naming/BinaryOperatorParameterName`

* fix `Style/AccessorGrouping`

* fix `Style/InverseMethods`

* fix `Style/IfUnlessModifier`

* fix `Style/MultilineIfModifier`

* fix `Style/MultipleComparison`

* fix `Style/SoleNestedConditional`

* fix `Style/UnpackFirst`

* fix `Security/MarshalLoad`

* fix `Style/GuardClause`

* fix `Style/Documentation`

* fix `Style/MultilineBlockChain`

* partially fix `Metrics/BlockNesting`

* fix `Layout/LineLength`

* fix `Style/GlobalVars`

updates rgeo#336

.rubocop.yml

@@ -1,7 +1,7 @@
 inherit_from: .rubocop_todo.yml
 
 AllCops:
-  TargetRubyVersion: 2.5
+  TargetRubyVersion: 2.6
   NewCops: enable
 
 Layout/ParameterAlignment:
@@ -42,6 +42,10 @@ Naming/PredicateName:
 Style/CaseEquality:
   Enabled: false
 
+Style/GlobalVars:
+  Exclude:
+    - 'ext/geos_c_impl/extconf.rb'
+
 Style/NumericPredicate:
   Enabled: false