Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine Satellite and Capsule into a single scenario #842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented May 2, 2024

Contains #837

@ehelms ehelms changed the title Combine satellite Combine Satellite and Capsule into a single scenario May 3, 2024
@ehelms ehelms marked this pull request as ready for review May 3, 2024 00:38
@@ -2,12 +2,13 @@ module Procedures::Installer
class UpgradeRakeTask < ForemanMaintain::Procedure
metadata do
description 'Execute upgrade:run rake task'
confine do
feature(:foreman)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is run by the installer for Foreman/Katello

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this hurts anything and sets up for making a change later.

@ehelms
Copy link
Member Author

ehelms commented May 31, 2024

I would like to make this change to combine them, and then make #763 to move to explicit step definition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants