Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop list-versions command #841

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented May 2, 2024

No description provided.

@ehelms
Copy link
Member Author

ehelms commented May 15, 2024

@Griffin-Sullivan review for me?

Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove list-versions shouldn't we simultaneously remove --target-version?

@Griffin-Sullivan
Copy link
Contributor

Testing is being done on SatelliteQE/robottelo#14970

Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automation is running successfully.

@ehelms
Copy link
Member Author

ehelms commented May 28, 2024

If we remove list-versions shouldn't we simultaneously remove --target-version?

I wasn't going to quite yet as it ties into a lot of code and makes it more explicit what's happening. However, as there is only ever one version to upgrade to, I didn't see a reason to keep this command around.

@ehelms ehelms merged commit 71cd541 into theforeman:master May 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants