Fix the tags check for the release gem action #815
Conversation
.github/workflows/release.yml
Outdated
| create: | ||
| ref_type: tag | ||
| push: | ||
| # Pattern matched against refs/tags |
There was a problem hiding this comment.
Does this comment imply it will match against any refs? Or is it just tags? I think we could just drop this comment as the code tells.
There was a problem hiding this comment.
@sbernhard any thoughts on this?
There was a problem hiding this comment.
The workflow starts if you push any tag.
In https://github.com/ATIX-AG/foreman_acd/actions/runs/8615551200 we use the same approach with success :-)
If you want, we can drop the comment. Should I?
There was a problem hiding this comment.
I think we can drop the comment. But I do wonder if we need to limit this to - 'v*'
There was a problem hiding this comment.
Normally, tags are only created for releases. Additionally, the gem is only released in the theforeman org: https://github.com/theforeman/foreman_maintain/pull/815/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R15
I can not see any other tag than release tags.
There was a problem hiding this comment.
Normally, tags are only created for releases. Additionally, the gem is only released in the theforeman org:
You said it yourself, normally. I'd prefer to limit this to the tag structure we know we use to be on the safe side
sbernhard
force-pushed
the
fix_tags_check
branch
from
f88aa8f
to
916d60e
Compare
See theforeman/actions#50