Factor out the target version to a method #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows copying the scenario without having to modify the target version everywhere. Ideally more steps would be taken out and reused.
|
I think Rubocop gets confused by the complex ways to define classes. There's some heavy meta-programming going on. |
|
I think this is a good change, #705 means we won't have to make it in but a few extra places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows copying the scenario without having to modify the target version everywhere. Ideally more steps would be taken out and reused.
This should probably be applied to many files, but first I'd like to get approval on the idea before I put in too much effort only to have to redo it.