Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37461 - Don't use the Kickstart rhsm for RHEL 8 #10169

Merged
merged 1 commit into from
May 20, 2024

Conversation

stejskalleos
Copy link
Contributor

The rhsm command has some issues on RHEL 8,
before it was not enabled for RHEL8 until the PR#9745.

refs bf03a25

Copy link

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, I've tested the PR and it works as expected.
and, now that we are just using kickstart_rhsm for RHEL9 and beyond, shouldn't the PR title/commit message be s/Don't use the Kickstart rhsm for RHEL 9/Don't use the Kickstart rhsm for RHEL 8?

The rhsm command has some issues on RHEL 8,
before it was not enabled for RHEL8 until the PR#9745.

refs bf03a25
@stejskalleos stejskalleos changed the title Fixes #37461 - Don't use the Kickstart rhsm for RHEL 9 Fixes #37461 - Don't use the Kickstart rhsm for RHEL 8 May 17, 2024
@stejskalleos
Copy link
Contributor Author

@Gauravtalreja1 Thanks for testing and the sharp eye! Title and commit message changed to RHEL 8

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall that RHEL 8 has a completely different implementation of the rhsm command compared to RHEL 9. CI is still running, but feel free to merge it yourself once it's green.

@ShimShtein ShimShtein merged commit 3b135d0 into theforeman:develop May 20, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants