-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include hashes in production builds of assets #10125
base: develop
Are you sure you want to change the base?
Conversation
@@ -153,6 +153,12 @@ const coreConfig = function() { | |||
'webpack/assets/javascripts/bundle.js' | |||
); | |||
config.context = path.resolve(__dirname, '..'); | |||
if (config.mode == 'production') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some reason, this is always true, and I don't understand it.
Okay, maybe I'm not as smart as I thought…
|
I feel like I need |
} | ||
config.output = { | ||
path: outputPath, | ||
publicPath: '/webpack/' + pluginName + '/', | ||
filename: chunkFilename, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am almost sure this will break plugins, but I've not tested it yet
draft, as this only does it for core, not plugins