Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubygem-foreman_rh_cloud to 9.0.56 #10743

Open
wants to merge 1 commit into
base: rpm/3.9
Choose a base branch
from
Open

Update rubygem-foreman_rh_cloud to 9.0.56 #10743

wants to merge 1 commit into from

Conversation

chris1984
Copy link
Member

No description provided.

@pr-processor pr-processor bot added Not yet reviewed RPM Stable branch PRs that are opened against a stable branch. Usually a cherry pick labels Apr 29, 2024
ekohl
ekohl requested changes Apr 29, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please first make sure nightly is updated and then cherry pick all commits to stable branches.

@chris1984
Copy link
Member Author

Please first make sure nightly is updated and then cherry pick all commits to stable branches.

@ekohl here is the nightly one I just made:

#10744

Once that goes in I will change this to a cherry-pick of that

@evgeni
Copy link
Member

evgeni commented Apr 30, 2024

That's merged now.

Please also update rpm/3.10 :)

@chris1984
Copy link
Member Author

That's merged now.

Please also update rpm/3.10 :)

Updated and all green for 3.9 :)

@chris1984 chris1984 requested a review from ekohl May 21, 2024 17:26
ekohl
ekohl requested changes May 22, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pick all the relevant commits and don't squash in commits into the cherry pick commit. This maintains the proper history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl requested changes

Assignees
No one assigned
Labels
RPM Stable branch PRs that are opened against a stable branch. Usually a cherry pick Waiting on contributor
Projects
None yet
Milestone
No milestone
3 participants
@chris1984 @evgeni @ekohl