Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick - Bump nodejs-theforeman-vendor/builder to 13.0.1 to 3.10 #10683

Open
wants to merge 2 commits into
base: rpm/3.10
Choose a base branch
from
Open

Cherrypick - Bump nodejs-theforeman-vendor/builder to 13.0.1 to 3.10 #10683

wants to merge 2 commits into from

Conversation

chris1984
Copy link
Member

No description provided.

@pr-processor pr-processor bot added Not yet reviewed RPM Stable branch PRs that are opened against a stable branch. Usually a cherry pick labels Apr 10, 2024
@chris1984 chris1984 changed the title Bump nodejs-theforeman-vendor to 13.0.1 Cherrypick - Bump nodejs-theforeman-vendor to 13.0.1 to 3.10 Apr 10, 2024
@chris1984
Copy link
Member Author

@theforeman/packaging here is the CP for 3.10

@evgeni
Copy link
Member

evgeni commented Apr 11, 2024

I think we also should pick the nodejs-theforeman-builder changes from develop, I have no idea what happens if those two get out of sync.

@chris1984 chris1984 changed the title Cherrypick - Bump nodejs-theforeman-vendor to 13.0.1 to 3.10 Cherrypick - Bump nodejs-theforeman-vendor/builder to 13.0.1 to 3.10 Apr 11, 2024
@chris1984
Copy link
Member Author

Brought in the builder cherrypick too, scratch builds passed but failing on repoclosure?

@chris1984
Copy link
Member Author

@theforeman/packaging any help here would be appreciated

@chris1984 chris1984 mentioned this pull request Apr 16, 2024
Merged
evgeni
evgeni approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be merged whenever the next 3.10.z is being prepared (otherwise it'll break plugin building until then).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni approved these changes

Assignees
No one assigned
Labels
RPM Stable branch PRs that are opened against a stable branch. Usually a cherry pick
Projects
None yet
Milestone
No milestone
2 participants
@chris1984 @evgeni