Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy gitconfig into build container #10387

Open
wants to merge 1 commit into
base: rpm/develop
Choose a base branch
from
Open

Copy gitconfig into build container #10387

wants to merge 1 commit into from

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Feb 1, 2024

This makes running update commands inside the container work.

ekohl
ekohl reviewed Feb 1, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't handle ~/.config/git/config. Would this also work if the file doesn't exist?

@ehelms
Copy link
Member Author

ehelms commented Feb 2, 2024

This doesn't handle ~/.config/git/config. Would this also work if the file doesn't exist?

Are you asking if we could use that path instead? or also mount it?

@ekohl
Copy link
Member

ekohl commented Feb 2, 2024

Mostly wondering what happens if you attempt to mount a location that doesn't exist

@ehelms
Copy link
Member Author

ehelms commented Feb 2, 2024

Mostly wondering what happens if you attempt to mount a location that doesn't exist

It will yell at you:

Error: statfs /home/ehelms/.config/git/config: no such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

Assignees
No one assigned
Labels
Not yet reviewed RPM
Projects
None yet
Milestone
No milestone
2 participants
@ehelms @ekohl