feat(vendor-core): update to jquery 3 #479
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Apr 25, 2024
There was a problem hiding this comment.
Out of interest, why pin to these specific versions instead of a wider range? And would the latest jquery version work?
There was a problem hiding this comment.
Good point, I'm not sure why I used that version, gonna run some tests and update this
There was a problem hiding this comment.
updated, had to do one small change for the in the core pr as focusout was removed
BREAKING CHANGE: Updates jquery,datatables,select2. replaces jquery.cookie with js-cookie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Updates jquery,datatables,select2. replaces jquery.cookie with js-cookie