Use global registration after renaming Smart Proxy Server #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maximiliankolb
commented
May 16, 2024
maximiliankolb
commented
- I am familiar with the contributing guidelines.
|
The PR preview for dd62652 is available at theforeman-foreman-documentation-preview-pr-3033.surge.sh The following output files are affected by this PR: |
maximiliankolb
force-pushed
the
rename_smart_proxy_global_registration
branch
from
2f65977
to
dd62652
Compare
ekohl
reviewed
May 21, 2024
@ekohl Can you please explain why not? If you make a valid case, perhaps we could implement a REX job for re-registration. But AFAIK, we have been fine with global reg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.