Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported OS+arch for orcharhino #3029

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maximiliankolb
Copy link
Contributor

Please cherry-pick my commits into:

  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8)

Copy link

The PR preview for 6b820f0 is available at theforeman-foreman-documentation-preview-pr-3029.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

|Ubuntu 22.04 |aarch64, amd64
|===
* x86_64/amd64
* aarch64 and ppc64le for select operating systems
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* aarch64 and ppc64le for select operating systems
* aarch64 and ppc64le for selected operating systems

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "select" is correct here: https://www.merriam-webster.com/dictionary/select

Maybe @bangelic can weigh in?

Copy link
Contributor

@apinnick apinnick May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends what you are trying to say. "Select" is an ambiguous word, so I do not recommend it.
"Selected" implies that the user has selected some operating systems.

Maybe this:

  • x86_64/amd64 is supported by all operating systems.
  • aarch64 and ppc64le is supported by specific (or 'certain') operating systems.

@Lennonka Lennonka added the Waiting on contributor Requires an action from the author label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting on contributor Requires an action from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants