Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL to Ansible Galaxy User guide #3026

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix URL to Ansible Galaxy User guide #3026

merged 1 commit into from
May 21, 2024

Conversation

maximiliankolb
Copy link
Contributor

Please cherry-pick my commits into:

  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8)

@github-actions GitHub Actions
Copy link

github-actions bot commented May 16, 2024 •
edited

The PR preview for 2cd5ada is available at theforeman-foreman-documentation-preview-pr-3026.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

Lennonka
Lennonka approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@Lennonka Lennonka left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links works.

Would you mind updating it in all maintained versions?

guides/common/modules/proc_synchronizing-ansible-collections.adoc Outdated Show resolved Hide resolved
maximiliankolb
maximiliankolb commented May 21, 2024
View reviewed changes
Copy link
Contributor Author

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased to "master" and applied feedback by Lena. Will merge with green GHA.

guides/common/modules/proc_synchronizing-ansible-collections.adoc Outdated Show resolved Hide resolved
@maximiliankolb maximiliankolb merged commit 377f09a into theforeman:master May 21, 2024
8 checks passed
@maximiliankolb maximiliankolb deleted the fix_ansible_url branch May 21, 2024 07:03
@maximiliankolb
Copy link
Contributor Author

Merged to "master" and cherry-picked:
076a35c..dba651a 3.10 -> 3.10
90269ac..9815a98 3.9 -> 3.9
06f9b0d..7f77000 3.8 -> 3.8
992384f..15548f7 3.7 -> 3.7
c88c018..8ed8681 3.6 -> 3.6
c4ec708..124ec1d 3.5 -> 3.5
64e1f6c..4cffa1f 3.4 -> 3.4
7f81ac6..c997336 3.3 -> 3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lennonka Lennonka Lennonka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maximiliankolb @Lennonka