Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify GPG public key extraction process and update keyserver URIs #3024

Conversation

lumarel
Copy link
Contributor

@lumarel lumarel commented May 15, 2024

I already had twice the issue to make the connection between the gpg --verify Release.gpg Release commands output and the gpg --recv-keys, so this change extends that part.

And recently we noticed, that the receiving from hkp://keyserver.ubuntu.com does not work anymore -> switches this to hkps://

Please cherry-pick my commits into:

  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • Foreman 3.4/Katello 4.6 (EL8 only)
  • Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only; orcharhino 6.4/6.5 on EL8 only)
  • We do not accept PRs for Foreman older than 3.3.

Copy link

github-actions bot commented May 15, 2024

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lumarel I've checked the examples for Debian 11. I'd not add the stdout, but the rest LGTM

@lumarel lumarel force-pushed the feature/extend-extracting-gpg-key-fingerprints branch from d9d2902 to 522c4c7 Compare May 20, 2024 14:01
@lumarel
Copy link
Contributor Author

lumarel commented May 20, 2024

@maximiliankolb Thank you for the help, I think I figured it out 👍🏻

Co-authored-by: AkshayGadhaveRH <97217993+AkshayGadhaveRH@users.noreply.github.com>
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small suggestion, rest LGTM.

Co-authored-by: Maximilian Kolb <mail@maximilian-kolb.de>
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lukas, LGTM

@maximiliankolb maximiliankolb merged commit 11b062e into theforeman:master May 21, 2024
8 checks passed
maximiliankolb pushed a commit that referenced this pull request May 21, 2024
maximiliankolb pushed a commit that referenced this pull request May 21, 2024
@maximiliankolb
Copy link
Contributor

Merged to "master" and cherry-picked:
dba651a..bc9fcae 3.10 -> 3.10
9815a98..d3321a3 3.9 -> 3.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants