Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update feedback module in Satellite #3022

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Update feedback module in Satellite #3022

merged 1 commit into from
Jun 5, 2024

Conversation

Lennonka
Copy link
Contributor

@Lennonka Lennonka commented May 15, 2024 •
edited

With migration from Bugzilla to Jira, we need to update the way users can provide feedback.

This has to be merged on June 5, not sooner!

Requested in: https://issues.redhat.com/browse/SAT-25170

Please cherry-pick my commits into:

  • Foreman 3.11
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • Foreman 3.4/Katello 4.6 (EL8 only)
  • Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only; orcharhino 6.4/6.5 on EL8 only)
  • We do not accept PRs for Foreman older than 3.3.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 15, 2024 •
edited

The PR preview for fb5d041 is available at theforeman-foreman-documentation-preview-pr-3022.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

bangelic
bangelic approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@bangelic bangelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apinnick
Copy link
Contributor

@Lennonka Will you also update the RN module? Or should I create a separate issue for that?

@Lennonka
Copy link
Contributor Author

Lennonka commented May 16, 2024 •
edited

@Lennonka Will you also update the RN module? Or should I create a separate issue for that?

@apinnick Oh, right, downstream! I will update that too, thank you for the reminder.

@Lennonka Lennonka force-pushed the update-feedback-module-sat branch from 16dfacb to ca21461 Compare May 16, 2024 13:16
@Lennonka Lennonka force-pushed the update-feedback-module-sat branch from ca21461 to fb5d041 Compare May 16, 2024 14:14
@Lennonka Lennonka added the Waiting for date Merging has to wait untila particular date specified in the PR label May 24, 2024
@Lennonka Lennonka removed the Waiting for date Merging has to wait untila particular date specified in the PR label Jun 5, 2024
@Lennonka Lennonka merged commit 5bb7b76 into theforeman:master Jun 5, 2024
8 checks passed
@Lennonka Lennonka deleted the update-feedback-module-sat branch June 5, 2024 11:34
@Lennonka
Copy link
Contributor Author

Lennonka commented Jun 5, 2024

Cherry-picked:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apinnick apinnick apinnick left review comments

@maximiliankolb maximiliankolb maximiliankolb approved these changes

@bangelic bangelic bangelic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Lennonka @apinnick @maximiliankolb @bangelic