Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove steps from generating content #3017

Merged
merged 3 commits into from
May 24, 2024
Merged

Remove steps from generating content #3017

merged 3 commits into from
May 24, 2024

Conversation

bangelic
Copy link
Contributor

It was decided that certain steps in generating content are not
necessary due to conflicting statements about
importability of syncable
exports.

Please cherry-pick my commits into:

  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • Foreman 3.4/Katello 4.6 (EL8 only)
  • Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only; orcharhino 6.4/6.5 on EL8 only)
  • We do not accept PRs for Foreman older than 3.3.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

The PR preview for 086a348 is available at theforeman-foreman-documentation-preview-pr-3017.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

Lennonka
Lennonka requested changes May 15, 2024
View reviewed changes
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weren't you supposed to move it to another module? Also, your Jira issue is requesting further improvements. Where are those?

@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Not yet reviewed labels May 15, 2024
@parthaa
Copy link
Contributor

parthaa commented May 16, 2024 •
edited

Weren't you supposed to move it to another module? Also, your Jira issue is requesting further improvements. Where are those?

I think the instructions for syncing syncable exports via custom cdn is listed in another doc. We don't need those steps in this doc. Basically this is no longer true 6.12 onwards.

You cannot directly import Syncable Format exports.
Instead, on the importing {ProjectServer} you must:

The customers are recommended to do import syncable same way as the default one via hammer.

@bangelic
Copy link
Contributor Author

I'll revert the snippet back to its original file and then update here. That snippet works across other areas of documentation so I shouldn't have done that.

@bangelic
Remove steps from generating content
ff9af76 
It was decided that certain steps in generating content
are not
necessary due to conflicting statements about
importability of syncable
exports.
@bangelic
Fix snip file and add content
0493638 
Snip file restored and info from snip file that needed
to be removed
specifically for this section to avoid contradictory
statements was put
in the section.
@bangelic bangelic force-pushed the bangelic-SAT-24844-Conflicting-statements-about-importability-of-syncable-exports branch from d5d500c to 0493638 Compare May 17, 2024 17:09
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels May 17, 2024
Lennonka
Lennonka requested changes May 20, 2024
View reviewed changes
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nitpicks.
The snippet itself could probably use improvement.

guides/common/modules/proc_exporting-the-library-environment-in-a-syncable-format.adoc Outdated Show resolved Hide resolved
guides/common/modules/proc_exporting-the-library-environment-in-a-syncable-format.adoc Outdated Show resolved Hide resolved
guides/common/modules/proc_exporting-the-library-environment-in-a-syncable-format.adoc Outdated Show resolved Hide resolved
guides/common/modules/proc_exporting-the-library-environment-in-a-syncable-format.adoc Outdated Show resolved Hide resolved
@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Needs re-review labels May 20, 2024
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels May 20, 2024
Lennonka
Lennonka approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lennonka Lennonka merged commit db67994 into theforeman:master May 24, 2024
8 checks passed
Lennonka pushed a commit that referenced this pull request May 24, 2024
@bangelic @Lennonka
Remove steps from generating content (#3017)
e6e5e38 
* Remove steps from generating content

It was decided that certain steps in generating content
are not
necessary due to conflicting statements about
importability of syncable
exports.

* Fix snip file and add content

Snip file restored and info from snip file that needed
to be removed
specifically for this section to avoid contradictory
statements was put
in the section.

* Content cleanup for clarity
Lennonka pushed a commit that referenced this pull request May 24, 2024
@bangelic @Lennonka
Remove steps from generating content (#3017)
945efd1 
* Remove steps from generating content

It was decided that certain steps in generating content
are not
necessary due to conflicting statements about
importability of syncable
exports.

* Fix snip file and add content

Snip file restored and info from snip file that needed
to be removed
specifically for this section to avoid contradictory
statements was put
in the section.

* Content cleanup for clarity
Lennonka pushed a commit that referenced this pull request May 24, 2024
@bangelic @Lennonka
Remove steps from generating content (#3017)
fee9c30 
* Remove steps from generating content

It was decided that certain steps in generating content
are not
necessary due to conflicting statements about
importability of syncable
exports.

* Fix snip file and add content

Snip file restored and info from snip file that needed
to be removed
specifically for this section to avoid contradictory
statements was put
in the section.

* Content cleanup for clarity
Lennonka pushed a commit that referenced this pull request May 24, 2024
@bangelic @Lennonka
Remove steps from generating content (#3017)
1930438 
* Remove steps from generating content

It was decided that certain steps in generating content
are not
necessary due to conflicting statements about
importability of syncable
exports.

* Fix snip file and add content

Snip file restored and info from snip file that needed
to be removed
specifically for this section to avoid contradictory
statements was put
in the section.

* Content cleanup for clarity
Lennonka pushed a commit that referenced this pull request May 24, 2024
@bangelic @Lennonka
Remove steps from generating content (#3017)
66d2ac6 
* Remove steps from generating content

It was decided that certain steps in generating content
are not
necessary due to conflicting statements about
importability of syncable
exports.

* Fix snip file and add content

Snip file restored and info from snip file that needed
to be removed
specifically for this section to avoid contradictory
statements was put
in the section.

* Content cleanup for clarity
Lennonka pushed a commit that referenced this pull request May 24, 2024
@bangelic @Lennonka
Remove steps from generating content (#3017)
76152e0 
* Remove steps from generating content

It was decided that certain steps in generating content
are not
necessary due to conflicting statements about
importability of syncable
exports.

* Fix snip file and add content

Snip file restored and info from snip file that needed
to be removed
specifically for this section to avoid contradictory
statements was put
in the section.

* Content cleanup for clarity
Lennonka pushed a commit that referenced this pull request May 24, 2024
@bangelic @Lennonka
Remove steps from generating content (#3017)
7dcbb43 
* Remove steps from generating content

It was decided that certain steps in generating content
are not
necessary due to conflicting statements about
importability of syncable
exports.

* Fix snip file and add content

Snip file restored and info from snip file that needed
to be removed
specifically for this section to avoid contradictory
statements was put
in the section.

* Content cleanup for clarity
Lennonka pushed a commit that referenced this pull request May 24, 2024
@bangelic @Lennonka
Remove steps from generating content (#3017)
532a967 
* Remove steps from generating content

It was decided that certain steps in generating content
are not
necessary due to conflicting statements about
importability of syncable
exports.

* Fix snip file and add content

Snip file restored and info from snip file that needed
to be removed
specifically for this section to avoid contradictory
statements was put
in the section.

* Content cleanup for clarity
Lennonka pushed a commit that referenced this pull request May 24, 2024
@bangelic @Lennonka
Remove steps from generating content (#3017)
880bfae 
* Remove steps from generating content

It was decided that certain steps in generating content
are not
necessary due to conflicting statements about
importability of syncable
exports.

* Fix snip file and add content

Snip file restored and info from snip file that needed
to be removed
specifically for this section to avoid contradictory
statements was put
in the section.

* Content cleanup for clarity
@Lennonka
Copy link
Contributor

Cherry-picked:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lennonka Lennonka Lennonka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bangelic @parthaa @Lennonka