Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an assembly per each LB config use case #3008

Merged
merged 21 commits into from
May 22, 2024

Conversation

asteflova
Copy link
Contributor

@asteflova asteflova commented May 7, 2024

The current way the procedures for configuring LB are documented is rather confusing -- a lot of different procedures are included within one assembly (yes Puppet/no Puppet, custom certs/default certs), and it takes quite some time to figure out which procedures are related to which use case. With this PR, I aim to create multiple assemblies where each assembly guides users through their scenario from beginning to end:

  • Users can now find all related procedures and other information (prerequisites, limitations) under one assembly heading.

  • The number of xrefs leading to other procedures has been reduced; there is no need for them now.

  • Each assembly now clearly links to support limitations (this is to address https://bugzilla.redhat.com/show_bug.cgi?id=2251030 ).

  • While I was at it, I also reworded procedure introductions to make them more descriptive and user-focused (mainly by removing self-referential wording like "This section/procedure")

  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • Foreman 3.4/Katello 4.6 (EL8 only)
  • Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only; orcharhino 6.4/6.5 on EL8 only)
  • We do not accept PRs for Foreman older than 3.3.

Copy link

github-actions bot commented May 7, 2024

Includes renaming orcharhino-specific prereq section
@asteflova asteflova marked this pull request as ready for review May 9, 2024 20:15
@asteflova asteflova changed the title Lb config assemblies Create an assembly per each LB config use case May 9, 2024
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of nitpicks

@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Not yet reviewed labels May 15, 2024
Co-authored-by: Zuzana Lena Ansorgová <zuansorg@redhat.com>
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels May 20, 2024
@asteflova asteflova requested a review from Lennonka May 20, 2024 15:29
@Lennonka Lennonka added Waiting on contributor Requires an action from the author and removed Needs re-review labels May 20, 2024
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels May 21, 2024
@asteflova asteflova requested a review from Lennonka May 21, 2024 06:13
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGBT... I mean LGTM+

@asteflova asteflova merged commit 35c8814 into theforeman:master May 22, 2024
8 checks passed
asteflova added a commit that referenced this pull request May 23, 2024
* Create assembly files for LB config scenarios

* Add LB config assembly intros

* Add LB config prerequisites

Includes renaming orcharhino-specific prereq section

* Include managing Puppet limitations in each related LB assembly

---------

Co-authored-by: Zuzana Lena Ansorgová <zuansorg@redhat.com>
(cherry picked from commit 35c8814)
@asteflova
Copy link
Contributor Author

Merged to "master" and cherry-picked:

72013f0..1a08c74 3.11 -> 3.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants