-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an assembly per each LB config use case #3008
Conversation
The PR preview for 439f243 is available at theforeman-foreman-documentation-preview-pr-3008.surge.sh The following output files are affected by this PR: |
Includes renaming orcharhino-specific prereq section
860a3d2
to
0c66046
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of nitpicks
guides/common/modules/ref_prerequisites-configuring-smartproxyservers-for-load-balancing.adoc
Outdated
Show resolved
Hide resolved
...figuring-smartproxyservers-with-default-ssl-certificates-for-load-balancing-with-puppet.adoc
Outdated
Show resolved
Hide resolved
...figuring-smartproxyservers-with-default-ssl-certificates-for-load-balancing-with-puppet.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Zuzana Lena Ansorgová <zuansorg@redhat.com>
...nfiguring-smartproxyservers-with-custom-ssl-certificates-for-load-balancing-with-puppet.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/ref_prerequisites-configuring-smartproxyservers-for-load-balancing.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGBT... I mean LGTM+
* Create assembly files for LB config scenarios * Add LB config assembly intros * Add LB config prerequisites Includes renaming orcharhino-specific prereq section * Include managing Puppet limitations in each related LB assembly --------- Co-authored-by: Zuzana Lena Ansorgová <zuansorg@redhat.com> (cherry picked from commit 35c8814)
The current way the procedures for configuring LB are documented is rather confusing -- a lot of different procedures are included within one assembly (yes Puppet/no Puppet, custom certs/default certs), and it takes quite some time to figure out which procedures are related to which use case. With this PR, I aim to create multiple assemblies where each assembly guides users through their scenario from beginning to end:
Users can now find all related procedures and other information (prerequisites, limitations) under one assembly heading.
The number of xrefs leading to other procedures has been reduced; there is no need for them now.
Each assembly now clearly links to support limitations (this is to address https://bugzilla.redhat.com/show_bug.cgi?id=2251030 ).
While I was at it, I also reworded procedure introductions to make them more descriptive and user-focused (mainly by removing self-referential wording like "This section/procedure")
I am familiar with the contributing guidelines.
Please cherry-pick my commits into: