Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add other EL support for HAProxy installation #2964

Closed
wants to merge 2 commits into from
Closed

Add other EL support for HAProxy installation #2964

wants to merge 2 commits into from

Conversation

mjivraja
Copy link
Contributor

We mentioned a maximum of 2 Enterprise Linux versions for HAProxy load balancer installation. However, after confirmation with the respective team, even EL 7 is supported for the installation.

https://bugzilla.redhat.com/show_bug.cgi?id=2093048

Please cherry-pick my commits into:

  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (planned Satellite 6.15; orcharhino 6.8)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • Foreman 3.4/Katello 4.6 (EL8 only)
  • Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only; orcharhino 6.4/6.5 on EL8 only)
  • We do not accept PRs for Foreman older than 3.3.

@mjivraja
Copy link
Contributor Author

This still needs double-validation technically that I feel. Also, I need to verify the cherry-picking version.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 15, 2024 •
edited

The PR preview for efc37ce is available at theforeman-foreman-documentation-preview-pr-2964.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@mjivraja mjivraja added the Needs tech review Requires a review from the technical perspective label Apr 15, 2024
@mjivraja mjivraja force-pushed the Add-EL-version-support-HAproxy-installation-master branch from fce37b3 to a2ef968 Compare April 19, 2024 05:23
@mjivraja mjivraja requested a review from ehelms April 30, 2024 06:37
@ehelms
Copy link
Member

ehelms commented May 1, 2024

I do not see any changes listed in the PR.

@mjivraja
Add other EL support for HAProxy installation
b6eed32 
We mentioned maximum 2 Enterprise Linux version for HAProxy load
balancer installation. But after confirmation with respective team, even
EL 7 is supported for the installation.

https://bugzilla.redhat.com/show_bug.cgi?id=2093048
@mjivraja
Revert EL7
efc37ce
@mjivraja mjivraja force-pushed the Add-EL-version-support-HAproxy-installation-master branch from a2ef968 to efc37ce Compare May 2, 2024 06:11
@mjivraja
Copy link
Contributor Author

mjivraja commented May 2, 2024

I do not see any changes listed in the PR.

Is it strange? I am seeing changes in Commit section but not in Files Changed.
@Lennonka @maximiliankolb Am I missing something?

@mjivraja
Copy link
Contributor Author

mjivraja commented May 2, 2024

Wait, I guess we already satisfied the requirements in our earlier PR - c140d08#diff-344f84d157fe0249a38bd3e5aa32e1a8f40768794d400edec2bafaa2a39c2dfd

@ehelms Does the above change look good to you?

@Lennonka
Copy link
Contributor

Lennonka commented May 2, 2024

@mjivraja the second commit is reverting the first commit

@mjivraja
Copy link
Contributor Author

mjivraja commented May 2, 2024

@mjivraja the second commit is reverting the first commit

Yeah 👍

@maximiliankolb
Copy link
Contributor

@mjivraja There's no diff to review right now. Please rebase and check again.

@mjivraja
Copy link
Contributor Author

@mjivraja There's no diff to review right now. Please rebase and check again.

Right. I am closing this PR as the desired changes have been covered in earlier PR. After the inputs of @ehelms it seems there is no further changes required.

@mjivraja mjivraja closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehelms ehelms Awaiting requested review from ehelms

Assignees
No one assigned
Labels
Needs tech review Requires a review from the technical perspective Not yet reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mjivraja @ehelms @Lennonka @maximiliankolb