Remove deb CV filters from tests and make special deb test #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evgeni can't get forklift to work for me so I still need to record the fixtures for the deb playbook |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content view filter tests were using deb repositories which was breaking on live Satellites. I decided to remove the deb filters and rules from the
content_view_filter_*test playbooks and give it it's own simple playbook.I also simplified the
content_view_filter_infotest since it was outdated after creating thecontent_view_filter_rulemodule. The test now just creates a filter and makes sure the info module works on it. No need to run an info on every type of filter, since the other tests are much more comprehensive.