-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add description to location module #1724
base: develop
Are you sure you want to change the base?
Feature: Add description to location module #1724
Conversation
Signed-off-by: Patrick Pfurtscheller <patrick@pfurtscheller.org>
On a first glance, your changes look good (and you have a picky editor 😉). |
Signed-off-by: Patrick Pfurtscheller <patrick@pfurtscheller.org>
Hi, |
I'll try to ping you with some pointers next week when back in the office. |
Okay, here I am. Let's see if we can get this going for you. There is some basic documentation at https://github.com/theforeman/foreman-ansible-modules/blob/develop/docs/testing.md#writing-tests but I'll try to re-phrase it (and you tell me which version was better understandable ;) ) You'll need:
Once you have that, you should be ready to go. You can verify the overall setup by calling an existing test like As a counter-test, you can run You can now run |
Currently - even though the REST API and python utils would allow it - the location module does not implement the parameter
description
.However, this can be helpful especially if a company uses e.g. computed site codes as locations in Foreman or Satellite that are not easily understandable at first glance (but help with automation).