stop using requests

[evgeni]

this is using Apipie/apypie#129 and some dirty tricks to make it work

don't try this at home, kids

[mdellweg]

Looks like a castling to me...
I'm about to take the exact opposite turn here: pulp/squeezer#106

[evgeni]

"heh"

the ever-returning problem is the python-package-dependency-handling of ansible-collection (which is effectively non-existant)

[evgeni]

this was done as part of #609, but it seems ansible's Request does that for us instead.

[ekohl]

Doesn't Ansible's HTTP client code itself implement this?

[evgeni]

So far, nope

[evgeni]

So this works (mostly?) and is a good ground for the discussion.

Currently open issues:

• the url += '?' + six.moves.urllib.parse.urlencode(params) is ugly (as pointed out by Ewoud)
• the callback is totally untested
• it might have broken a shit ton unicode things
• I am using a method only available in Ansible 2.10+ -- time to say good bye to 2.9? Or make that use requests?

[ekohl]

the url += '?' + six.moves.urllib.parse.urlencode(params) is ugly (as pointed out by Ewoud)

Is there at least an upstream issue to support it? I think your approach to pop the parameter is safe, even if it's added, but not having to think about it is even nicer.

I am using a method only available in Ansible 2.10+ -- time to say good bye to 2.9? Or make that use requests?

That also means dropping the ability to run on EL7, right? I don't know how much that's used, but I'd consider keeping it for a bit longer.

[evgeni]

I am using a method only available in Ansible 2.10+ -- time to say good bye to 2.9? Or make that use requests?

That also means dropping the ability to run on EL7, right? I don't know how much that's used, but I'd consider keeping it for a bit longer.

"On EL7 by using only official packages", yes. Nothing forbids to run pip installed Ansible there.

[evgeni]

the url += '?' + six.moves.urllib.parse.urlencode(params) is ugly (as pointed out by Ewoud)

Is there at least an upstream issue to support it? I think your approach to pop the parameter is safe, even if it's added, but not having to think about it is even nicer.

I don't think upstream cares, but I can ask.
Their wrapper is not trying to be requests-compatible and just expects the url parameter to contain all parameters already. Which is totally fine.

[ekohl]

If it's an issue closed as WONTFIX that at least is a good code comment why it's done.