Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to the inventory plugin to retrieve a list of ansible roles enabled within foreman #1444

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

stuwilkins
Copy link

@stuwilkins stuwilkins commented Jul 24, 2022

This addition to the inventory plugin pulls the defined ansible roles from foreman and sets the variable foreman_ansible_roles

The option is set via the wants_ansible_roles setting.

@mdellweg
Copy link
Member

This repository contains so much more than just the inventory plugin. Please drop the name of the component somewhere in the title of this issue and the commit messages.

@stuwilkins stuwilkins changed the title Add option to retrieve ansible roles from foreman Add option to the inventory plugin to retrieve a list of ansible roles enabled within foreman Jul 25, 2022
Added option to inventory plugin to pull the list of
ansible roles defined by foreman for a given host. The list
of ansible roles are stored in the foreman_roles variable.
Rename inventory plugin variable to be foreman_ansible_roles to be
consistent with how thw variable is defined for plays within
foreman.
@stuwilkins
Copy link
Author

@mdellweg Thanks for the prompt reply, and thanks for the work on this collection, we use much more than just the plugin but I added this to help with using Tower and Foreman together.

I changed the commit messages and also the PR. Please let me know if you need anything else.

@mdellweg
Copy link
Member

That is much better now. And i hope people more familiar with the inventory than me will be triggered by this. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants