Remove waiting for the remote address of a TensorHandle from within the scope of acquiring a shared lock in RemoteMgr
#67703
+25
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
exported_pr_634150808
branch
from
77c5226
to
09d8c1c
Compare
copybara-service
bot
changed the title
TensorHandle from within the scope of acquiring a shared lock in RemoteMgrTensorHandle from within the scope of acquiring a shared lock in RemoteMgr
… the scope of acquiring a shared lock in `RemoteMgr` Waiting for the remote address itself involves acquiring a lock and is independent of acquiring the `RemoteMgr`'s shared lock. Making the first acquisition nested inside the second should not be done. This may lead to deadlocks. PiperOrigin-RevId: 634150808
copybara-service
bot
force-pushed
the
exported_pr_634150808
branch
from
09d8c1c
to
a25b1ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove waiting for the remote address of a
TensorHandlefrom within the scope of acquiring a shared lock inRemoteMgrWaiting for the remote address itself involves acquiring a lock and is independent of acquiring the
RemoteMgr's shared lock. Making the first acquisition nested inside the second should not be done. This may lead to deadlocks.