Update api_who_reacted.cpp #27774
Open
Update api_who_reacted.cpp #27774
+95
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I split the original RegenerateParticipants function into two separate functions: UpdateExistingParticipants and AddNewParticipants
|
|
This code improves readability and structure by using functional transformations and filtering, as well as explicitly updating userpics
|
I couldn't think of a reason it must've done this way. It's unnecessary to generate two independent thunks of machine code that will only be called sequentially, especially when building with LTO. |
Tinaochoa8462
approved these changes
May 14, 2024
He explains it and it is a very valid reason
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now I split the original
RegenerateParticipantsfunction into two separate functions:UpdateExistingParticipantsandAddNewParticipants. The first one updates information about existing participants, while the second one adds new participants. NowRegenerateParticipantscalls these two functions sequentially to update the participants list. This improves the code structure, making it more understandable and modular.