Disable crash reports entirely through macro #16794
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves compile time and binary size. Guarding code by preprocessor is the only effective way to guarantee its elimination, even in most modern C++. And more importantly, one do not need to care of it for porting to old Qt.
|
Why are you doing that? |
|
@ilya-fedin I didn't ask you meaning of life |
john-preston
requested changes
Aug 11, 2021
There was a problem hiding this comment.
@mymedia2 I don't like the idea of doing this using preprocessor. I think there should be core/not_started_window module, that contains code without preprocessor that is always built and core/crash_report_window module, that uses this core/not_started_window module. core/crash_report_window module should be excluded from the build in CMake using remove_target_sources in case of crash reports not being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves compile time and binary size. Guarding code by preprocessor is the only effective way to guarantee its elimination, even in most modern C++. And more importantly, one do not need to care of it for porting to old Qt.