-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default helm image for helm-upgrade-from- tasks #1252
Conversation
Hi @mikecroft. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Catlin Output
Catlin script lint Output
|
/ok-to-test |
task/helm-upgrade-from-source/0.4/helm-upgrade-from-source.yaml
Outdated
Show resolved
Hide resolved
Updates version number labels to match files Co-authored-by: Florian Hopfensperger <f.hopfensperger@gmail.com>
Catlin Output
Catlin script lint Output
|
/test pull-catalog-catlin-lint |
@vinamra28: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Catlin Output
Catlin script lint Output
|
Is there anything else I need to do to get this merged? It looks like it only needs approval, but I'm happy to add more changes if needed. |
Thank you very much for the PR. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
This PR updates the default image used in the
helm-upgrade-from-repo
andhelm-upgrade-from-source
tasks from v3.6.0 to v3.10.2.The main motivation for this change is that the existing version does not include the
--dependency-upgrade
option. This change therefore provides the ability for charts to not package their dependencies.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
contains
/kind <type>
. Valid types are bug, cleanup, design, documentation,feature, flake, misc, question, tep
File path follows
<kind>/<name>/<version>/name.yaml
Has
README.md
at<kind>/<name>/<version>/README.md
Has mandatory
metadata.labels
-app.kubernetes.io/version
the same as the<version>
of the resourceHas mandatory
metadata.annotations
tekton.dev/pipelines.minVersion
mandatory
spec.description
follows the conventionSee the contribution guide for more details.