-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JQ Tekton Task #1250
JQ Tekton Task #1250
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @jpmaida. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Catlin Output
Catlin script lint Output
|
Catlin Output
Catlin script lint Output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Catlin Output
Catlin script lint Output
|
Catlin Output
Catlin script lint Output
|
Catlin Output
Catlin script lint Output
|
Catlin Output
Catlin script lint Output
|
Catlin Output
Catlin script lint Output
|
Catlin Output
|
/retest |
Catlin Output
Catlin script lint Output
|
/retest |
@vinamra28 could u please help me about the pull-tekton-catalog-integration-tests test. It's failing and I don't know why since I haven't changed any source code, just documentation. |
@jpmaida, can you please try running your task on your cluster once and see if it fails there as well? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpmaida, best way to test task before submitting to catalog is using k8s cluster and running ./test/run-test.sh task <taskname> <version>
which in your case would be ./test/run-test.sh task jq 0.1
Also can you please squash your commits?
Catlin Output
Catlin script lint Output
|
Catlin Output
Catlin script lint Output
|
Catlin Output
Catlin script lint Output
|
|
Catlin Output
Catlin script lint Output
|
Catlin Output
Catlin script lint Output
|
Catlin Output
Catlin script lint Output
|
Catlin Output
Catlin script lint Output
|
@vinamra28 ... I am sorry, I tried to squash the commits but ended up doing a big mess. Everytime I tried to squash all commits I ended up creating a new merge commit. I don't know how to fix/do it and would appreciate some help. |
Changes
JQ Tekton Task
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
contains
/kind <type>
. Valid types are bug, cleanup, design, documentation,feature, flake, misc, question, tep
File path follows
<kind>/<name>/<version>/name.yaml
Has
README.md
at<kind>/<name>/<version>/README.md
Has mandatory
metadata.labels
-app.kubernetes.io/version
the same as the<version>
of the resourceHas mandatory
metadata.annotations
tekton.dev/pipelines.minVersion
mandatory
spec.description
follows the conventionSee the contribution guide for more details.