Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JQ Tekton Task #1250

Closed
wants to merge 29 commits into from
Closed

JQ Tekton Task #1250

wants to merge 29 commits into from

Conversation

jpmaida
Copy link
Contributor

@jpmaida jpmaida commented Apr 9, 2024

Changes

JQ Tekton Task

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Follows the authoring recommendations
  • Includes docs (if user facing)
  • Includes tests (for new tasks or changed functionality)
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Commit messages follow commit message best practices
  • Has a kind label. You can add one by adding a comment on this PR that
    contains /kind <type>. Valid types are bug, cleanup, design, documentation,
    feature, flake, misc, question, tep
  • Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
    • File path follows <kind>/<name>/<version>/name.yaml

    • Has README.md at <kind>/<name>/<version>/README.md

    • Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

    • Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

    • mandatory spec.description follows the convention

        ```
      
        spec:
          description: >-
            one line summary of the resource
      
            Paragraph(s) to describe the resource.
        ```
      

See the contribution guide for more details.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vinamra28 after the PR has been reviewed.
You can assign the PR to them by writing /assign @vinamra28 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 9, 2024
@tekton-robot
Copy link

Hi @jpmaida. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 9, 2024
@tekton-robot
Copy link

Catlin Output
FILE: task/jq/0.1/jq.yaml
ERROR: Task: tekton.dev/v1beta1 - name: "jq" is missing a mandatory annotation for minimum pipeline version("tekton.dev/pipelines.minVersion")
WARN : Step "jq-script" uses image "$(params.image)" that contains variables; skipping validation
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jq-jq-script line 6:
  echo $(params.input) | jq $(params.script) | tee $(results.jq-script-outcome.path)
       ^-------------^ SC2046 (warning): Quote this to prevent word splitting.
       ^-------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.
                            ^--------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                   ^-- SC2046 (warning): Quote this to prevent word splitting.


In jq-jq-script line 8:
  cat $(params.input) | jq $(params.script) | tee $(results.jq-script-outcome.path)
      ^-------------^ SC2046 (warning): Quote this to prevent word splitting.
      ^-------------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                           ^--------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                  ^-- SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

@tekton-robot
Copy link

Catlin Output
FILE: task/jq/0.1/jq.yaml
WARN : Step "jq-script" uses image "$(params.image)" that contains variables; skipping validation
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jq-jq-script line 6:
  echo $(params.input) | jq $(params.script) | tee $(results.jq-script-outcome.path)
       ^-------------^ SC2046 (warning): Quote this to prevent word splitting.
       ^-------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.
                            ^--------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                   ^-- SC2046 (warning): Quote this to prevent word splitting.


In jq-jq-script line 8:
  cat $(params.input) | jq $(params.script) | tee $(results.jq-script-outcome.path)
      ^-------------^ SC2046 (warning): Quote this to prevent word splitting.
      ^-------------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                           ^--------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                  ^-- SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 10, 2024
@tekton-robot
Copy link

Catlin Output
FILE: task/jq/0.1/jq.yaml
WARN : Step "jq-script" uses image "$(params.image)" that contains variables; skipping validation
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jq-jq-script line 6:
  jq $(params.options) $(params.filter) <<< "$(params.input)" | tee $(results.jq-script-outcome.path)
     ^---------------^ SC2046 (warning): Quote this to prevent word splitting.
                       ^--------------^ SC2046 (warning): Quote this to prevent word splitting.
                                        ^-^ SC3011 (warning): In POSIX sh, here-strings are undefined.
                                                                    ^-- SC2046 (warning): Quote this to prevent word splitting.


In jq-jq-script line 8:
  jq $(params.options) $(params.filter) $(params.input) | tee $(results.jq-script-outcome.path)
     ^---------------^ SC2046 (warning): Quote this to prevent word splitting.
                       ^--------------^ SC2046 (warning): Quote this to prevent word splitting.
                                        ^-------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                              ^-- SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC3011 -- In POSIX sh, here-strings are und...

ERROR: /bin/sh, [-n] failed:
jq-jq-script: line 6: syntax error: unexpected redirection

@tekton-robot
Copy link

Catlin Output
FILE: task/jq/0.1/jq.yaml
WARN : Step "jq-script" uses image "$(params.image)" that contains variables; skipping validation
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jq-jq-script line 6:
  jq "$(params.options)" '$(params.filter)' <<< "$(params.input)" | tee "$(results.jq-script-outcome.path)"
                                            ^-^ SC3011 (warning): In POSIX sh, here-strings are undefined.

For more information:
  https://www.shellcheck.net/wiki/SC3011 -- In POSIX sh, here-strings are und...

ERROR: /bin/sh, [-n] failed:
jq-jq-script: line 6: syntax error: unexpected redirection

@tekton-robot
Copy link

Catlin Output
FILE: task/jq/0.1/jq.yaml
WARN : Step "jq-script" uses image "$(params.image)" that contains variables; skipping validation
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jq-jq-script line 6:
  echo "$(params.input)" > tmp.json
       ^---------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

For more information:
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

@tekton-robot
Copy link

Catlin Output
FILE: task/jq/0.1/jq.yaml
WARN : Step "jq-script" uses image "$(params.image)" that contains variables; skipping validation
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jq-jq-script line 6:
  echo "$(params.input)" > tmp.json
       ^---------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

For more information:
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

@tekton-robot
Copy link

Catlin Output
FILE: task/jq/0.1/jq.yaml
WARN : Step "jq-script" uses image "$(params.image)" that contains variables; skipping validation
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In jq-jq-script line 5:
  echo "$(params.input)" > tmp.json
       ^---------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

For more information:
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

@tekton-robot
Copy link

Catlin Output
FILE: task/jq/0.1/jq.yaml
WARN : Step "jq-script" uses image "$(params.image)" that contains variables; skipping validation

@jpmaida
Copy link
Contributor Author

jpmaida commented Apr 12, 2024

/retest

@tekton-robot
Copy link

Catlin Output
FILE: task/42crunch-api-security-audit/0.2/42crunch-api-security-audit.yaml
FILE: task/anchore-cli/0.1/anchore-cli.yaml
WARN : Step "anchore-cli" uses image "$(params.ANCHORE_CLI_IMAGE)" that contains variables; skipping validation
FILE: task/ansible-builder/0.1/ansible-builder.yaml
WARN : Step "ansible-builder-create" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/ansible-runner/0.2/ansible-runner.yaml
WARN : Step "requirements" uses image "$(params.image)" that contains variables; skipping validation
WARN : Step "run-playbook" uses image "$(params.image)" that contains variables; skipping validation
FILE: task/buildah/0.7/buildah.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/dockerslim-build/0.1/dockerslim-build.yaml
WARN : Step "docker-build" uses image "$(params.builder_image)" that contains variables; skipping validation
WARN : Step "docker-push" uses image "$(params.push_image)" that contains variables; skipping validation
FILE: task/golang-fuzz/0.1/golang-fuzz.yaml
WARN : Step "fuzz" uses image "docker.io/library/golang:$(params.version)" that contains variables; skipping validation
FILE: task/hugo/0.1/hugo.yaml
Catlin script lint Output
WARN : step: redhat-dependency-analytics is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In redhat-dependency-analytics-redhat-dependency-analytics line 6:
    jq -n {} | jq --arg exit_code "1" '. + {exit_code: $exit_code}' > $OUTPUT_FILE_PATH
                                                                      ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    jq -n {} | jq --arg exit_code "1" '. + {exit_code: $exit_code}' > "$OUTPUT_FILE_PATH"


In redhat-dependency-analytics-redhat-dependency-analytics line 10:
    printf "\n[ERROR] Failed to install dependencies from requirements.txt.\n$error_message"
           ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".


In redhat-dependency-analytics-redhat-dependency-analytics line 26:
  cp $MANIFEST_FILE_PATH /shared/requirements.txt
     ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  cp "$MANIFEST_FILE_PATH" /shared/requirements.txt


In redhat-dependency-analytics-redhat-dependency-analytics line 44:
    ((elapsed_time++))
    ^----------------^ SC3006 (warning): In POSIX sh, standalone ((..)) is undefined.
                  ^-- SC3018 (warning): In POSIX sh, ++ is undefined.


In redhat-dependency-analytics-redhat-dependency-analytics line 47:
  export EXHORT_PIP_FREEZE=$(cat /shared/pip_freeze.txt | base64 -w 0)
         ^---------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                           ^-- SC2046 (warning): Quote this to prevent word splitting.
                                 ^--------------------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.


In redhat-dependency-analytics-redhat-dependency-analytics line 48:
  export EXHORT_PIP_SHOW=$(cat /shared/pip_show.txt | base64 -w 0)
         ^-------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                         ^-- SC2046 (warning): Quote this to prevent word splitting.
                               ^------------------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.


In redhat-dependency-analytics-redhat-dependency-analytics line 53:
export EXHORT_GO_MVS_LOGIC_ENABLED=$(echo "$(params.use-go-mvs-logic)")
       ^-------------------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                   ^-- SC2046 (warning): Quote this to prevent word splitting.
                                          ^--------------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
  https://www.shellcheck.net/wiki/SC3006 -- In POSIX sh, standalone ((..)) is...

@jpmaida
Copy link
Contributor Author

jpmaida commented May 17, 2024

/retest

@jpmaida
Copy link
Contributor Author

jpmaida commented May 17, 2024

@vinamra28 could u please help me about the pull-tekton-catalog-integration-tests test. It's failing and I don't know why since I haven't changed any source code, just documentation.

@vinamra28
Copy link
Member

@jpmaida, can you please try running your task on your cluster once and see if it fails there as well?

@jpmaida
Copy link
Contributor Author

jpmaida commented May 27, 2024

@jpmaida, can you please try running your task on your cluster once and see if it fails there as well?

Screenshot_20240527_144734

Screenshot_20240527_144843

Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmaida, best way to test task before submitting to catalog is using k8s cluster and running ./test/run-test.sh task <taskname> <version> which in your case would be ./test/run-test.sh task jq 0.1

Also can you please squash your commits?

task/jq/0.1/tests/pipelinerun.yaml Outdated Show resolved Hide resolved
task/jq/0.1/tests/print-result.yaml Outdated Show resolved Hide resolved
@tekton-robot
Copy link

Catlin Output
FILE: task/anchore-cli/0.1/anchore-cli.yaml
WARN : Step "anchore-cli" uses image "$(params.ANCHORE_CLI_IMAGE)" that contains variables; skipping validation
FILE: task/helm-render-manifests-from-repo/0.1/helm-render-manifests-from-repo.yaml
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-repo-upgrade-from-repo line 5:
REPO=`echo "$(params.chart_name)" | cut -d "/" -f 1`
     ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
           ^--------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

Did you mean: 
REPO=$(echo "$(params.chart_name)" | cut -d "/" -f 1)


In helm-upgrade-from-repo-upgrade-from-repo line 7:
helm repo add $REPO "$(params.helm_repo)"
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
helm repo add "$REPO" "$(params.helm_repo)"


In helm-upgrade-from-repo-upgrade-from-repo line 11:
helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
                                                                        ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                                               ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-source-upgrade line 6:
helm upgrade --install --wait --values "$(params.charts_dir)/$(params.values_file)" --namespace "$(params.release_namespace)" --version "$(params.release_version)" "$(params.release_name)" "$(params.charts_dir)" --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
                                                                                                                                                                                                                                                               ^----------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

WARN : step: redhat-dependency-analytics is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In redhat-dependency-analytics-redhat-dependency-analytics line 6:
    jq -n {} | jq --arg exit_code "1" '. + {exit_code: $exit_code}' > $OUTPUT_FILE_PATH
                                                                      ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    jq -n {} | jq --arg exit_code "1" '. + {exit_code: $exit_code}' > "$OUTPUT_FILE_PATH"


In redhat-dependency-analytics-redhat-dependency-analytics line 10:
    printf "\n[ERROR] Failed to install dependencies from requirements.txt.\n$error_message"
           ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".


In redhat-dependency-analytics-redhat-dependency-analytics line 26:
  cp $MANIFEST_FILE_PATH /shared/requirements.txt
     ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  cp "$MANIFEST_FILE_PATH" /shared/requirements.txt


In redhat-dependency-analytics-redhat-dependency-analytics line 44:
    ((elapsed_time++))
    ^----------------^ SC3006 (warning): In POSIX sh, standalone ((..)) is undefined.
                  ^-- SC3018 (warning): In POSIX sh, ++ is undefined.


In redhat-dependency-analytics-redhat-dependency-analytics line 47:
  export EXHORT_PIP_FREEZE=$(cat /shared/pip_freeze.txt | base64 -w 0)
         ^---------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                           ^-- SC2046 (warning): Quote this to prevent word splitting.
                                 ^--------------------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.


In redhat-dependency-analytics-redhat-dependency-analytics line 48:
  export EXHORT_PIP_SHOW=$(cat /shared/pip_show.txt | base64 -w 0)
         ^-------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                         ^-- SC2046 (warning): Quote this to prevent word splitting.
                               ^------------------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.


In redhat-dependency-analytics-redhat-dependency-analytics line 53:
export EXHORT_GO_MVS_LOGIC_ENABLED=$(echo "$(params.use-go-mvs-logic)")
       ^-------------------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                   ^-- SC2046 (warning): Quote this to prevent word splitting.
                                          ^--------------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
  https://www.shellcheck.net/wiki/SC3006 -- In POSIX sh, standalone ((..)) is...

@tekton-robot
Copy link

Catlin Output
FILE: task/anchore-cli/0.1/anchore-cli.yaml
WARN : Step "anchore-cli" uses image "$(params.ANCHORE_CLI_IMAGE)" that contains variables; skipping validation
FILE: task/helm-render-manifests-from-repo/0.1/helm-render-manifests-from-repo.yaml
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-repo-upgrade-from-repo line 5:
REPO=`echo "$(params.chart_name)" | cut -d "/" -f 1`
     ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
           ^--------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

Did you mean: 
REPO=$(echo "$(params.chart_name)" | cut -d "/" -f 1)


In helm-upgrade-from-repo-upgrade-from-repo line 7:
helm repo add $REPO "$(params.helm_repo)"
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
helm repo add "$REPO" "$(params.helm_repo)"


In helm-upgrade-from-repo-upgrade-from-repo line 11:
helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
                                                                        ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                                               ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-source-upgrade line 6:
helm upgrade --install --wait --values "$(params.charts_dir)/$(params.values_file)" --namespace "$(params.release_namespace)" --version "$(params.release_version)" "$(params.release_name)" "$(params.charts_dir)" --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
                                                                                                                                                                                                                                                               ^----------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

@tekton-robot
Copy link

Catlin Output
FILE: task/anchore-cli/0.1/anchore-cli.yaml
WARN : Step "anchore-cli" uses image "$(params.ANCHORE_CLI_IMAGE)" that contains variables; skipping validation
FILE: task/helm-render-manifests-from-repo/0.1/helm-render-manifests-from-repo.yaml
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-repo-upgrade-from-repo line 5:
REPO=`echo "$(params.chart_name)" | cut -d "/" -f 1`
     ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
           ^--------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

Did you mean: 
REPO=$(echo "$(params.chart_name)" | cut -d "/" -f 1)


In helm-upgrade-from-repo-upgrade-from-repo line 7:
helm repo add $REPO "$(params.helm_repo)"
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
helm repo add "$REPO" "$(params.helm_repo)"


In helm-upgrade-from-repo-upgrade-from-repo line 11:
helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
                                                                        ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                                               ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-source-upgrade line 6:
helm upgrade --install --wait --values "$(params.charts_dir)/$(params.values_file)" --namespace "$(params.release_namespace)" --version "$(params.release_version)" "$(params.release_name)" "$(params.charts_dir)" --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
                                                                                                                                                                                                                                                               ^----------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

Copy link

linux-foundation-easycla bot commented May 31, 2024

CLA Missing ID CLA Not Signed

@tekton-robot
Copy link

Catlin Output
FILE: task/42crunch-api-security-audit/0.2/42crunch-api-security-audit.yaml
FILE: task/anchore-cli/0.1/anchore-cli.yaml
WARN : Step "anchore-cli" uses image "$(params.ANCHORE_CLI_IMAGE)" that contains variables; skipping validation
FILE: task/ansible-builder/0.1/ansible-builder.yaml
WARN : Step "ansible-builder-create" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/ansible-runner/0.2/ansible-runner.yaml
WARN : Step "requirements" uses image "$(params.image)" that contains variables; skipping validation
WARN : Step "run-playbook" uses image "$(params.image)" that contains variables; skipping validation
FILE: task/buildah/0.6/buildah.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/buildah/0.7/buildah.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/dockerslim-build/0.1/dockerslim-build.yaml
WARN : Step "docker-build" uses image "$(params.builder_image)" that contains variables; skipping validation
WARN : Step "docker-push" uses image "$(params.push_image)" that contains variables; skipping validation
FILE: task/golang-fuzz/0.1/golang-fuzz.yaml
WARN : Step "fuzz" uses image "docker.io/library/golang:$(params.version)" that contains variables; skipping validation
FILE: task/gradle/0.4/gradle.yaml
WARN : Step "gradle-tasks" uses image "$(params.GRADLE_IMAGE)" that contains variables; skipping validation
FILE: task/helm-render-manifests-from-repo/0.1/helm-render-manifests-from-repo.yaml
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-repo-upgrade-from-repo line 5:
REPO=`echo "$(params.chart_name)" | cut -d "/" -f 1`
     ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
           ^--------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

Did you mean: 
REPO=$(echo "$(params.chart_name)" | cut -d "/" -f 1)


In helm-upgrade-from-repo-upgrade-from-repo line 7:
helm repo add $REPO "$(params.helm_repo)"
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
helm repo add "$REPO" "$(params.helm_repo)"


In helm-upgrade-from-repo-upgrade-from-repo line 11:
helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
                                                                        ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                                               ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-source-upgrade line 6:
helm upgrade --install --wait --values "$(params.charts_dir)/$(params.values_file)" --namespace "$(params.release_namespace)" --version "$(params.release_version)" "$(params.release_name)" "$(params.charts_dir)" --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
                                                                                                                                                                                                                                                               ^----------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

WARN : step: redhat-dependency-analytics is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In redhat-dependency-analytics-redhat-dependency-analytics line 6:
    jq -n {} | jq --arg exit_code "1" '. + {exit_code: $exit_code}' > $OUTPUT_FILE_PATH
                                                                      ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    jq -n {} | jq --arg exit_code "1" '. + {exit_code: $exit_code}' > "$OUTPUT_FILE_PATH"


In redhat-dependency-analytics-redhat-dependency-analytics line 10:
    printf "\n[ERROR] Failed to install dependencies from requirements.txt.\n$error_message"
           ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".


In redhat-dependency-analytics-redhat-dependency-analytics line 26:
  cp $MANIFEST_FILE_PATH /shared/requirements.txt
     ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  cp "$MANIFEST_FILE_PATH" /shared/requirements.txt


In redhat-dependency-analytics-redhat-dependency-analytics line 44:
    ((elapsed_time++))
    ^----------------^ SC3006 (warning): In POSIX sh, standalone ((..)) is undefined.
                  ^-- SC3018 (warning): In POSIX sh, ++ is undefined.


In redhat-dependency-analytics-redhat-dependency-analytics line 47:
  export EXHORT_PIP_FREEZE=$(cat /shared/pip_freeze.txt | base64 -w 0)
         ^---------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                           ^-- SC2046 (warning): Quote this to prevent word splitting.
                                 ^--------------------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.


In redhat-dependency-analytics-redhat-dependency-analytics line 48:
  export EXHORT_PIP_SHOW=$(cat /shared/pip_show.txt | base64 -w 0)
         ^-------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                         ^-- SC2046 (warning): Quote this to prevent word splitting.
                               ^------------------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.


In redhat-dependency-analytics-redhat-dependency-analytics line 53:
export EXHORT_GO_MVS_LOGIC_ENABLED=$(echo "$(params.use-go-mvs-logic)")
       ^-------------------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                   ^-- SC2046 (warning): Quote this to prevent word splitting.
                                          ^--------------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
  https://www.shellcheck.net/wiki/SC3006 -- In POSIX sh, standalone ((..)) is...

@tekton-robot
Copy link

Catlin Output
FILE: task/42crunch-api-security-audit/0.2/42crunch-api-security-audit.yaml
FILE: task/anchore-cli/0.1/anchore-cli.yaml
WARN : Step "anchore-cli" uses image "$(params.ANCHORE_CLI_IMAGE)" that contains variables; skipping validation
FILE: task/ansible-builder/0.1/ansible-builder.yaml
WARN : Step "ansible-builder-create" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/ansible-runner/0.2/ansible-runner.yaml
WARN : Step "requirements" uses image "$(params.image)" that contains variables; skipping validation
WARN : Step "run-playbook" uses image "$(params.image)" that contains variables; skipping validation
FILE: task/buildah/0.6/buildah.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/buildah/0.7/buildah.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/dockerslim-build/0.1/dockerslim-build.yaml
WARN : Step "docker-build" uses image "$(params.builder_image)" that contains variables; skipping validation
WARN : Step "docker-push" uses image "$(params.push_image)" that contains variables; skipping validation
FILE: task/golang-fuzz/0.1/golang-fuzz.yaml
WARN : Step "fuzz" uses image "docker.io/library/golang:$(params.version)" that contains variables; skipping validation
FILE: task/gradle/0.4/gradle.yaml
WARN : Step "gradle-tasks" uses image "$(params.GRADLE_IMAGE)" that contains variables; skipping validation
FILE: task/helm-render-manifests-from-repo/0.1/helm-render-manifests-from-repo.yaml
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-repo-upgrade-from-repo line 5:
REPO=`echo "$(params.chart_name)" | cut -d "/" -f 1`
     ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
           ^--------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

Did you mean: 
REPO=$(echo "$(params.chart_name)" | cut -d "/" -f 1)


In helm-upgrade-from-repo-upgrade-from-repo line 7:
helm repo add $REPO "$(params.helm_repo)"
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
helm repo add "$REPO" "$(params.helm_repo)"


In helm-upgrade-from-repo-upgrade-from-repo line 11:
helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
                                                                        ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                                               ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-source-upgrade line 6:
helm upgrade --install --wait --values "$(params.charts_dir)/$(params.values_file)" --namespace "$(params.release_namespace)" --version "$(params.release_version)" "$(params.release_name)" "$(params.charts_dir)" --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
                                                                                                                                                                                                                                                               ^----------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

WARN : step: redhat-dependency-analytics is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In redhat-dependency-analytics-redhat-dependency-analytics line 6:
    jq -n {} | jq --arg exit_code "1" '. + {exit_code: $exit_code}' > $OUTPUT_FILE_PATH
                                                                      ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    jq -n {} | jq --arg exit_code "1" '. + {exit_code: $exit_code}' > "$OUTPUT_FILE_PATH"


In redhat-dependency-analytics-redhat-dependency-analytics line 10:
    printf "\n[ERROR] Failed to install dependencies from requirements.txt.\n$error_message"
           ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".


In redhat-dependency-analytics-redhat-dependency-analytics line 26:
  cp $MANIFEST_FILE_PATH /shared/requirements.txt
     ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  cp "$MANIFEST_FILE_PATH" /shared/requirements.txt


In redhat-dependency-analytics-redhat-dependency-analytics line 44:
    ((elapsed_time++))
    ^----------------^ SC3006 (warning): In POSIX sh, standalone ((..)) is undefined.
                  ^-- SC3018 (warning): In POSIX sh, ++ is undefined.


In redhat-dependency-analytics-redhat-dependency-analytics line 47:
  export EXHORT_PIP_FREEZE=$(cat /shared/pip_freeze.txt | base64 -w 0)
         ^---------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                           ^-- SC2046 (warning): Quote this to prevent word splitting.
                                 ^--------------------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.


In redhat-dependency-analytics-redhat-dependency-analytics line 48:
  export EXHORT_PIP_SHOW=$(cat /shared/pip_show.txt | base64 -w 0)
         ^-------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                         ^-- SC2046 (warning): Quote this to prevent word splitting.
                               ^------------------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.


In redhat-dependency-analytics-redhat-dependency-analytics line 53:
export EXHORT_GO_MVS_LOGIC_ENABLED=$(echo "$(params.use-go-mvs-logic)")
       ^-------------------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                   ^-- SC2046 (warning): Quote this to prevent word splitting.
                                          ^--------------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
  https://www.shellcheck.net/wiki/SC3006 -- In POSIX sh, standalone ((..)) is...

@tekton-robot
Copy link

Catlin Output
FILE: task/42crunch-api-security-audit/0.2/42crunch-api-security-audit.yaml
FILE: task/anchore-cli/0.1/anchore-cli.yaml
WARN : Step "anchore-cli" uses image "$(params.ANCHORE_CLI_IMAGE)" that contains variables; skipping validation
FILE: task/ansible-builder/0.1/ansible-builder.yaml
WARN : Step "ansible-builder-create" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/ansible-runner/0.2/ansible-runner.yaml
WARN : Step "requirements" uses image "$(params.image)" that contains variables; skipping validation
WARN : Step "run-playbook" uses image "$(params.image)" that contains variables; skipping validation
FILE: task/buildah/0.6/buildah.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/buildah/0.7/buildah.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/dockerslim-build/0.1/dockerslim-build.yaml
WARN : Step "docker-build" uses image "$(params.builder_image)" that contains variables; skipping validation
WARN : Step "docker-push" uses image "$(params.push_image)" that contains variables; skipping validation
FILE: task/golang-fuzz/0.1/golang-fuzz.yaml
WARN : Step "fuzz" uses image "docker.io/library/golang:$(params.version)" that contains variables; skipping validation
FILE: task/gradle/0.4/gradle.yaml
WARN : Step "gradle-tasks" uses image "$(params.GRADLE_IMAGE)" that contains variables; skipping validation
FILE: task/helm-render-manifests-from-repo/0.1/helm-render-manifests-from-repo.yaml
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-repo-upgrade-from-repo line 5:
REPO=`echo "$(params.chart_name)" | cut -d "/" -f 1`
     ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
           ^--------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

Did you mean: 
REPO=$(echo "$(params.chart_name)" | cut -d "/" -f 1)


In helm-upgrade-from-repo-upgrade-from-repo line 7:
helm repo add $REPO "$(params.helm_repo)"
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
helm repo add "$REPO" "$(params.helm_repo)"


In helm-upgrade-from-repo-upgrade-from-repo line 11:
helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
                                                                        ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                                               ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-source-upgrade line 6:
helm upgrade --install --wait --values "$(params.charts_dir)/$(params.values_file)" --namespace "$(params.release_namespace)" --version "$(params.release_version)" "$(params.release_name)" "$(params.charts_dir)" --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
                                                                                                                                                                                                                                                               ^----------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

WARN : step: redhat-dependency-analytics is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In redhat-dependency-analytics-redhat-dependency-analytics line 6:
    jq -n {} | jq --arg exit_code "1" '. + {exit_code: $exit_code}' > $OUTPUT_FILE_PATH
                                                                      ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    jq -n {} | jq --arg exit_code "1" '. + {exit_code: $exit_code}' > "$OUTPUT_FILE_PATH"


In redhat-dependency-analytics-redhat-dependency-analytics line 10:
    printf "\n[ERROR] Failed to install dependencies from requirements.txt.\n$error_message"
           ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".


In redhat-dependency-analytics-redhat-dependency-analytics line 26:
  cp $MANIFEST_FILE_PATH /shared/requirements.txt
     ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  cp "$MANIFEST_FILE_PATH" /shared/requirements.txt


In redhat-dependency-analytics-redhat-dependency-analytics line 44:
    ((elapsed_time++))
    ^----------------^ SC3006 (warning): In POSIX sh, standalone ((..)) is undefined.
                  ^-- SC3018 (warning): In POSIX sh, ++ is undefined.


In redhat-dependency-analytics-redhat-dependency-analytics line 47:
  export EXHORT_PIP_FREEZE=$(cat /shared/pip_freeze.txt | base64 -w 0)
         ^---------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                           ^-- SC2046 (warning): Quote this to prevent word splitting.
                                 ^--------------------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.


In redhat-dependency-analytics-redhat-dependency-analytics line 48:
  export EXHORT_PIP_SHOW=$(cat /shared/pip_show.txt | base64 -w 0)
         ^-------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                         ^-- SC2046 (warning): Quote this to prevent word splitting.
                               ^------------------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.


In redhat-dependency-analytics-redhat-dependency-analytics line 53:
export EXHORT_GO_MVS_LOGIC_ENABLED=$(echo "$(params.use-go-mvs-logic)")
       ^-------------------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                   ^-- SC2046 (warning): Quote this to prevent word splitting.
                                          ^--------------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
  https://www.shellcheck.net/wiki/SC3006 -- In POSIX sh, standalone ((..)) is...

@tekton-robot
Copy link

Catlin Output
FILE: task/42crunch-api-security-audit/0.2/42crunch-api-security-audit.yaml
FILE: task/anchore-cli/0.1/anchore-cli.yaml
WARN : Step "anchore-cli" uses image "$(params.ANCHORE_CLI_IMAGE)" that contains variables; skipping validation
FILE: task/ansible-builder/0.1/ansible-builder.yaml
WARN : Step "ansible-builder-create" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/ansible-runner/0.2/ansible-runner.yaml
WARN : Step "requirements" uses image "$(params.image)" that contains variables; skipping validation
WARN : Step "run-playbook" uses image "$(params.image)" that contains variables; skipping validation
FILE: task/buildah/0.6/buildah.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/buildah/0.7/buildah.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/dockerslim-build/0.1/dockerslim-build.yaml
WARN : Step "docker-build" uses image "$(params.builder_image)" that contains variables; skipping validation
WARN : Step "docker-push" uses image "$(params.push_image)" that contains variables; skipping validation
FILE: task/golang-fuzz/0.1/golang-fuzz.yaml
WARN : Step "fuzz" uses image "docker.io/library/golang:$(params.version)" that contains variables; skipping validation
FILE: task/gradle/0.4/gradle.yaml
WARN : Step "gradle-tasks" uses image "$(params.GRADLE_IMAGE)" that contains variables; skipping validation
FILE: task/helm-render-manifests-from-repo/0.1/helm-render-manifests-from-repo.yaml
Catlin script lint Output
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-repo-upgrade-from-repo line 5:
REPO=`echo "$(params.chart_name)" | cut -d "/" -f 1`
     ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
           ^--------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

Did you mean: 
REPO=$(echo "$(params.chart_name)" | cut -d "/" -f 1)


In helm-upgrade-from-repo-upgrade-from-repo line 7:
helm repo add $REPO "$(params.helm_repo)"
              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
helm repo add "$REPO" "$(params.helm_repo)"


In helm-upgrade-from-repo-upgrade-from-repo line 11:
helm upgrade --wait --install --namespace "$(params.release_namespace)" $(params.release_name) $(params.chart_name) --debug --set "$(params.overwrite_values)"
                                                                        ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                                                               ^------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2005 -- Useless echo? Instead of 'echo $(...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In helm-upgrade-from-source-upgrade line 6:
helm upgrade --install --wait --values "$(params.charts_dir)/$(params.values_file)" --namespace "$(params.release_namespace)" --version "$(params.release_version)" "$(params.release_name)" "$(params.charts_dir)" --debug --set "$(params.overwrite_values)" $(params.upgrade_extra_params)
                                                                                                                                                                                                                                                               ^----------------------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

WARN : step: redhat-dependency-analytics is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In redhat-dependency-analytics-redhat-dependency-analytics line 6:
    jq -n {} | jq --arg exit_code "1" '. + {exit_code: $exit_code}' > $OUTPUT_FILE_PATH
                                                                      ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    jq -n {} | jq --arg exit_code "1" '. + {exit_code: $exit_code}' > "$OUTPUT_FILE_PATH"


In redhat-dependency-analytics-redhat-dependency-analytics line 10:
    printf "\n[ERROR] Failed to install dependencies from requirements.txt.\n$error_message"
           ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".


In redhat-dependency-analytics-redhat-dependency-analytics line 26:
  cp $MANIFEST_FILE_PATH /shared/requirements.txt
     ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  cp "$MANIFEST_FILE_PATH" /shared/requirements.txt


In redhat-dependency-analytics-redhat-dependency-analytics line 44:
    ((elapsed_time++))
    ^----------------^ SC3006 (warning): In POSIX sh, standalone ((..)) is undefined.
                  ^-- SC3018 (warning): In POSIX sh, ++ is undefined.


In redhat-dependency-analytics-redhat-dependency-analytics line 47:
  export EXHORT_PIP_FREEZE=$(cat /shared/pip_freeze.txt | base64 -w 0)
         ^---------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                           ^-- SC2046 (warning): Quote this to prevent word splitting.
                                 ^--------------------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.


In redhat-dependency-analytics-redhat-dependency-analytics line 48:
  export EXHORT_PIP_SHOW=$(cat /shared/pip_show.txt | base64 -w 0)
         ^-------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                         ^-- SC2046 (warning): Quote this to prevent word splitting.
                               ^------------------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.


In redhat-dependency-analytics-redhat-dependency-analytics line 53:
export EXHORT_GO_MVS_LOGIC_ENABLED=$(echo "$(params.use-go-mvs-logic)")
       ^-------------------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                   ^-- SC2046 (warning): Quote this to prevent word splitting.
                                          ^--------------------------^ SC2005 (style): Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
  https://www.shellcheck.net/wiki/SC3006 -- In POSIX sh, standalone ((..)) is...

@jpmaida
Copy link
Contributor Author

jpmaida commented May 31, 2024

@vinamra28 ... I am sorry, I tried to squash the commits but ended up doing a big mess. Everytime I tried to squash all commits I ended up creating a new merge commit. I don't know how to fix/do it and would appreciate some help.

@vinamra28
Copy link
Member

@jpmaida, for now can you please create a new PR and let's get this merged. Parallely can you please take a look at this

@jpmaida jpmaida closed this Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants