Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Shipwright CLI task #1246

Merged
merged 1 commit into from
May 17, 2024
Merged

Added Shipwright CLI task #1246

merged 1 commit into from
May 17, 2024

Conversation

siamaksade
Copy link
Contributor

Changes

Shipwright CLI Task is added for interacting with Shipwright Builds on a Kubernetes cluster

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Follows the authoring recommendations
  • Includes docs (if user facing)
  • Includes tests (for new tasks or changed functionality)
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Commit messages follow commit message best practices
  • Has a kind label. You can add one by adding a comment on this PR that
    contains /kind <type>. Valid types are bug, cleanup, design, documentation,
    feature, flake, misc, question, tep
  • Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
    • File path follows <kind>/<name>/<version>/name.yaml

    • Has README.md at <kind>/<name>/<version>/README.md

    • Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

    • Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

    • mandatory spec.description follows the convention

        ```
      
        spec:
          description: >-
            one line summary of the resource
      
            Paragraph(s) to describe the resource.
        ```
      

See the contribution guide for more details.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 4, 2024
@tekton-robot
Copy link

Hi @siamaksade. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 4, 2024
params:
- name: SHP_IMAGE
description: shp CLI container image to run this task
default: quay.io/siamaksade/shipwright-cli:0.12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @siamaksade 👋🏻, is there any public image available for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. updated to the cli image on shipwright quay.io org

@vinamra28
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 4, 2024
vdemeester added a commit to vdemeester/tektoncd-community that referenced this pull request Apr 5, 2024
Siamak is part of the openshift-pipelines teams, and is going to own
at least a task in `tektoncd/catalog` (see
tektoncd/catalog#1246).

I (vdemeester) am endorsing him.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
tekton-robot pushed a commit to tektoncd/community that referenced this pull request Apr 5, 2024
Siamak is part of the openshift-pipelines teams, and is going to own
at least a task in `tektoncd/catalog` (see
tektoncd/catalog#1246).

I (vdemeester) am endorsing him.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@vinamra28
Copy link
Member

/verify-owners

@vinamra28
Copy link
Member

@siamaksade, you might have got an tekton community invite from github, can you please accept that? 😅

task/shp/0.1/README.md Outdated Show resolved Hide resolved

| name | description | default |
| --------- | ------------------------------------------- | ---------------------------------------------|
| SHP_IMAGE | `shp` CLI container image to run this task. | `quay.io/siamaksade/shipwright-cli:0.12` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please update this with the new image present in task?

@siamaksade
Copy link
Contributor Author

@siamaksade, you might have got an tekton community invite from github, can you please accept that? 😅

I don't believe I have. I see the PR is merged to get added to the org but haven't received any invite emails.

@vinamra28
Copy link
Member

@siamaksade, you might have got an tekton community invite from github, can you please accept that? 😅

I don't believe I have. I see the PR is merged to get added to the org but haven't received any invite emails.

@afrittoli, can you please check/re-trigger the invite (if possible)? 😅

@siamaksade
Copy link
Contributor Author

org membership is resolved now

@vinamra28
Copy link
Member

/verify-owners

@tekton-robot tekton-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label May 14, 2024
@vinamra28
Copy link
Member

@siamaksade, will it be possible to squash the commits into one single meaningful commit? 😅

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siamaksade 🙏🏼 on squash 🙃

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@vinamra28
Copy link
Member

thanks @siamaksade 👍🏻
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
@tekton-robot tekton-robot merged commit 7d95827 into tektoncd:main May 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants