-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Shipwright CLI task #1246
Conversation
Hi @siamaksade. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
task/shp/0.1/shp.yaml
Outdated
params: | ||
- name: SHP_IMAGE | ||
description: shp CLI container image to run this task | ||
default: quay.io/siamaksade/shipwright-cli:0.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @siamaksade 👋🏻, is there any public image available for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey. updated to the cli image on shipwright quay.io org
/ok-to-test |
Siamak is part of the openshift-pipelines teams, and is going to own at least a task in `tektoncd/catalog` (see tektoncd/catalog#1246). I (vdemeester) am endorsing him. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Siamak is part of the openshift-pipelines teams, and is going to own at least a task in `tektoncd/catalog` (see tektoncd/catalog#1246). I (vdemeester) am endorsing him. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
/verify-owners |
@siamaksade, you might have got an tekton community invite from github, can you please accept that? 😅 |
task/shp/0.1/README.md
Outdated
|
||
| name | description | default | | ||
| --------- | ------------------------------------------- | ---------------------------------------------| | ||
| SHP_IMAGE | `shp` CLI container image to run this task. | `quay.io/siamaksade/shipwright-cli:0.12` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please update this with the new image present in task?
I don't believe I have. I see the PR is merged to get added to the org but haven't received any invite emails. |
@afrittoli, can you please check/re-trigger the invite (if possible)? 😅 |
org membership is resolved now |
/verify-owners |
@siamaksade, will it be possible to squash the commits into one single meaningful commit? 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siamaksade 🙏🏼 on squash 🙃
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks @siamaksade 👍🏻 |
Changes
Shipwright CLI Task is added for interacting with Shipwright Builds on a Kubernetes cluster
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
contains
/kind <type>
. Valid types are bug, cleanup, design, documentation,feature, flake, misc, question, tep
File path follows
<kind>/<name>/<version>/name.yaml
Has
README.md
at<kind>/<name>/<version>/README.md
Has mandatory
metadata.labels
-app.kubernetes.io/version
the same as the<version>
of the resourceHas mandatory
metadata.annotations
tekton.dev/pipelines.minVersion
mandatory
spec.description
follows the conventionSee the contribution guide for more details.