Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for issue #506 #507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Test for issue #506 #507

wants to merge 1 commit into from

Conversation

bradphelan
Copy link
Contributor

This shows issue #506 failing

@tsung-wei-huang
Copy link
Member

I am looking into that. thanks!

@tsung-wei-huang
Copy link
Member

@bradphelan The problem happens because tf::Semaphore or tf::CriticalSection is not thread-safe. In your case, multiple subflows will try to add their tasks into the critical section. Does this make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bradphelan @tsung-wei-huang