Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Mermaid dump support #273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IceflowRE
Copy link

Close #272

@tsung-wei-huang
Copy link
Member

Is there any web-based interface for users to visualize the dump file? Like https://dreampuf.github.io/GraphvizOnline/

Also, would you mind fixing the compile error in the CI?

@IceflowRE
Copy link
Author

IceflowRE commented Jan 18, 2021

https://mermaid-js.github.io/mermaid-live-editor

And yes of course but i wanted to get the first impression from you. The viszualize target is working tho.

@IceflowRE
Copy link
Author

IceflowRE commented Jan 18, 2021

CI is broken due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85282.

Will do a workaround later.

@tsung-wei-huang
Copy link
Member

@IceflowRE , your IDE looks perfect. Yes, I think your implementation idea is the right direction. Would you please be so nice to fix the CI error? Also, have you tried to compile your code with cuda (NVCC), and see if they can dump the cudaFlow correctly?

@tsung-wei-huang
Copy link
Member

I suggest adding a new section to the page Profile Taskflow Programs like "Visualize Your Taskflow with Mermaid Format" and add a detailed explanation with code examples. Later I will change the title to Profile and Visualization Taskflow Programs and include another similar section Visualize Your Taskflow with GraphViz Format. I think this is more organized -:)

@IceflowRE
Copy link
Author

I suggest adding a new section to the page Profile Taskflow Programs like "Visualize Your Taskflow with Mermaid Format" and add a detailed explanation with code examples. Later I will change the title to Profile and Visualization Taskflow Programs and include another similar section Visualize Your Taskflow with GraphViz Format. I think this is more organized -:)

Isn't there already a section in the quickstart?

@IceflowRE IceflowRE marked this pull request as ready for review January 27, 2021 14:49
@tsung-wei-huang
Copy link
Member

@IceflowRE thanks for this excellent work. I think we can make GraphViz a default argument to the dump method, or it causes compile errors for projects, including mine, that are using taskflow's dump already.

// in taskflow/core/taskflow.hpp
void dump(std::ostream& ostream, DumpFormat = tf::DumpFormat::Graphviz) const;
std::string dump(DumpFormat = DumpFormat::Graphviz) const;

In this case, you don't need to modify the other code examples that are using Graphviz by default. Would you be so nice to change it?

Also, it does not look like you provide the Mermaid-formated dump in cudaGraph here. The method tasks an std::ostream&, a const void* pointer to the parent node (just pointer value is printed in Graphviz), and a const std::string& to the name of the parent node. I think we need to add another parameter tf::DumpFormat in the last argument to the base class

I will come back to merge the pull later this week (sry quite busy these days)

@IceflowRE
Copy link
Author

Also, it does not look like you provide the Mermaid-formated dump in cudaGraph here. The method tasks an std::ostream&, a const void* pointer to the parent node (just pointer value is printed in Graphviz), and a const std::string& to the name of the parent node. I think we need to add another parameter tf::DumpFormat in the last argument to the base class

Actually there are a lot more dump functions ....

  • cuda graph
  • tensor
  • cuda task
  • cuda flow
  • cuda capturer

@IceflowRE IceflowRE changed the title Add Mermaid dump support [WIP] Add Mermaid dump support Feb 6, 2021
@IceflowRE
Copy link
Author

Also can take a few days, iam a bit busy and i havent Cuda installed yet to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mermaid dump support
2 participants