New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add Mermaid dump support #273
base: master
Are you sure you want to change the base?
Conversation
Is there any web-based interface for users to visualize the dump file? Like https://dreampuf.github.io/GraphvizOnline/ Also, would you mind fixing the compile error in the CI? |
https://mermaid-js.github.io/mermaid-live-editor And yes of course but i wanted to get the first impression from you. The viszualize target is working tho. |
fd59cea
to
8493fd1
Compare
CI is broken due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85282. Will do a workaround later. |
@IceflowRE , your IDE looks perfect. Yes, I think your implementation idea is the right direction. Would you please be so nice to fix the CI error? Also, have you tried to compile your code with cuda (NVCC), and see if they can dump the cudaFlow correctly? |
I suggest adding a new section to the page Profile Taskflow Programs like "Visualize Your Taskflow with Mermaid Format" and add a detailed explanation with code examples. Later I will change the title to Profile and Visualization Taskflow Programs and include another similar section Visualize Your Taskflow with GraphViz Format. I think this is more organized -:) |
8493fd1
to
b91d9fc
Compare
Isn't there already a section in the quickstart? |
@IceflowRE thanks for this excellent work. I think we can make GraphViz a default argument to the // in taskflow/core/taskflow.hpp
void dump(std::ostream& ostream, DumpFormat = tf::DumpFormat::Graphviz) const;
std::string dump(DumpFormat = DumpFormat::Graphviz) const; In this case, you don't need to modify the other code examples that are using Graphviz by default. Would you be so nice to change it? Also, it does not look like you provide the Mermaid-formated dump in cudaGraph here. The method tasks an I will come back to merge the pull later this week (sry quite busy these days) |
Actually there are a lot more dump functions ....
|
Also can take a few days, iam a bit busy and i havent Cuda installed yet to test it. |
Close #272