-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error when using Wyng with rclone #176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the target branch to '08wip'.
You can make this fix more complete if you change the earlier 'untar' assignment line to include the '-tmp' extension like so:
untar_cmd = [dest.cd + " && mkdir -p ./"+sdir+"-tmp
If you prefer not to, just let me know and I'll do it.
Ah I see, thanks. I don't have time today but I can make and test the change tomorrow. |
22472fd
to
3e75000
Compare
I rebased to the '08wip' branch and changed the 'untar' assignment, Just to see what happens, I also tested a version of Wyng with only the 'untar' change and that didn't work: Edit: I tested this again and actually it works if I just change the Edit 2: I improved the stability of my scripts for mounting with rclone and I was hit with this bug again today. So after all I believe it's safer to keep both changes. I restored the branch with both commits. Edit 3: And now I get the error |
8987254
to
3e75000
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this manually to avoid merge conflict.
A simple and perhaps not-so-elegant solution to issue #175.
Edit: actually this doesn't fix the issue.Edit 2: it does fix #175! 馃槂 I forgot to apply the pull request on my local version of Wyng.