Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when using Wyng with rclone #176

Closed
wants to merge 2 commits into from
Closed

Fix error when using Wyng with rclone #176

wants to merge 2 commits into from

Conversation

ldeso
Copy link

@ldeso ldeso commented Sep 22, 2023 •
edited

A simple and perhaps not-so-elegant solution to issue #175.

Edit: actually this doesn't fix the issue.
Edit 2: it does fix #175! 馃槂 I forgot to apply the pull request on my local version of Wyng.

@ldeso ldeso marked this pull request as draft September 22, 2023 11:53
@ldeso ldeso marked this pull request as ready for review September 22, 2023 12:01
@tasket tasket changed the base branch from main to 08wip September 23, 2023 01:48
tasket
tasket requested changes Sep 23, 2023
View reviewed changes
Copy link
Owner

@tasket tasket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the target branch to '08wip'.

You can make this fix more complete if you change the earlier 'untar' assignment line to include the '-tmp' extension like so:
untar_cmd = [dest.cd + " && mkdir -p ./"+sdir+"-tmp

If you prefer not to, just let me know and I'll do it.

@ldeso
Copy link
Author

ldeso commented Sep 23, 2023

Ah I see, thanks. I don't have time today but I can make and test the change tomorrow.

@ldeso ldeso force-pushed the fix-error-when-using-wyng-with-rclone branch from 22472fd to 3e75000 Compare September 24, 2023 13:31
@ldeso
Copy link
Author

ldeso commented Sep 24, 2023 •
edited

I rebased to the '08wip' branch and changed the 'untar' assignment, wyng send works.

Just to see what happens, I also tested a version of Wyng with only the 'untar' change and that didn't work: wyng send would hang indefinitely. wyng send would only work with a version of Wyng that has just the rm -df change, or that has both the rm -df change and the untar change.

Edit: I tested this again and actually it works if I just change the untar assignment, the line with rm -df is not necessary. So I'm going to remove that rm -df commit if that's okay with you.

Edit 2: I improved the stability of my scripts for mounting with rclone and I was hit with this bug again today. So after all I believe it's safer to keep both changes. I restored the branch with both commits.

Edit 3: And now I get the error rm: cannot remove 'Vol_800c73/S_20230930-212454': Directory not empty, so there might still be a problem somewhere... This could be avoid by switching from rm -df to rm -rf, but wouldn't that be a bit risky? Or maybe the problem could be fixed from rclone's side...

@ldeso ldeso force-pushed the fix-error-when-using-wyng-with-rclone branch 2 times, most recently from 8987254 to 3e75000 Compare September 30, 2023 18:43
@ldeso ldeso requested a review from tasket September 30, 2023 18:59
tasket
tasket approved these changes May 17, 2024
View reviewed changes
Copy link
Owner

@tasket tasket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this manually to avoid merge conflict.

@tasket tasket closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasket tasket tasket approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when using Wyng with rclone
2 participants
@ldeso @tasket