Refactoring of Monte Carlo transport #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on聽 See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
*beep* *bop* Hi, human. The Click here to see your results. |
|
Best to get this reviewed and merged before it gets more complex. |
wkerzendorf
reviewed
May 10, 2024
wkerzendorf
reviewed
May 10, 2024
| @@ -37,9 +35,7 @@ def geometry(self): | |||
|
|
|||
| @property | |||
| def model(self): | |||
There was a problem hiding this comment.
I think Asish can do this as part of his project
wkerzendorf
reviewed
May 10, 2024
wkerzendorf
reviewed
May 10, 2024
|
|
||
| Returns | ||
| ----------- | ||
| v: float, current velocity | ||
| frac: float, dv/dr for current shell | ||
| """ | ||
| shell_id = r_packet.current_shell_id | ||
| v_inner = numba_model.v_inner[shell_id] |
There was a problem hiding this comment.
how did this work? Numba model only had time_explosion?
There was a problem hiding this comment.
It didn't, this nonhomologous code is quite old now.
wkerzendorf
reviewed
May 10, 2024
andrewfullard
force-pushed
the
mc-refactor
branch
from
f39ce98
to
9157bd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摑 Description
Type: 馃
bugfixCleans up the Monte Carlo part of the code
馃殾 Testing
How did you test these changes?
鈽戯笍 Checklist
build_docslabel