-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convergence restructure #2518
base: master
Are you sure you want to change the base?
Convergence restructure #2518
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2518 +/- ##
==========================================
- Coverage 68.74% 68.72% -0.02%
==========================================
Files 165 166 +1
Lines 13999 14007 +8
==========================================
+ Hits 9623 9627 +4
- Misses 4376 4380 +4 ☔ View full report in Codecov by Sentry. |
*beep* *bop* Hi, human. The Click here to see the build log. |
Make different classes for different convergence strategies. |
Let's get this merged to help Deeksha work on convergence |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some tests for the new functions.
📝 Description
Type: 🎢
infrastructure
This PR will take convergence handling out of the simulation and into a new class.
🚦 Testing
How did you test these changes?