Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Lockfiles Manually #2412

Closed

Conversation

atharva-2001
Copy link
Member

📝 Description

*Type: 🚦 testing | 🎢 infrastructure

@wkerzendorf says we don't need to generate lockfiles every release. This PR steals code that generates lockfiles from the pre release workflow and puts it into a separate workflow.

At the moment I am duplicating a lot of code- is it possible to reuse actions from other workflows?

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@atharva-2001 atharva-2001 changed the title Generate Lockfiles manually Generate Lockfiles Manually Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7312e0b) 66.90% compared to head (b355bd6) 66.90%.
Report is 33 commits behind head on master.

❗ Current head b355bd6 differs from pull request most recent head 0a0aab3. Consider uploading reports for the commit 0a0aab3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2412   +/-   ##
=======================================
  Coverage   66.90%   66.90%           
=======================================
  Files         153      153           
  Lines       13596    13596           
=======================================
  Hits         9097     9097           
  Misses       4499     4499           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tardis-bot
Copy link
Contributor

*beep* *bop*
Hi human,
I ran benchmarks as you asked comparing master (7312e0b) and the latest commit (0a0aab3).
Here are the logs produced by ASV.
Results can also be downloaded as artifacts here.
Significantly changed benchmarks:

· No results found

All benchmarks:

· No results found

@atharva-2001
Copy link
Member Author

Closing this since I believe we won't be making lock files anymore using workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants