Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plasma Documentation #2109

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

isaacgsmith
Copy link
Member

📝 Description

I am planning on continuing Matthew's work on the plasma docs, so I am opening this PR based on his branch in #1896.

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

Write a complete description of your changes, including the necessary context or any piece of information required to understand your work.

Also, link issues affected by this pull request by using the keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tardis-bot
Copy link
Contributor

tardis-bot commented Jul 31, 2022

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@isaacgsmith isaacgsmith mentioned this pull request Jul 31, 2022
10 tasks
@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Merging #2109 (a546654) into master (35299f2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2109   +/-   ##
=======================================
  Coverage   61.46%   61.46%           
=======================================
  Files          75       75           
  Lines        8620     8620           
=======================================
  Hits         5298     5298           
  Misses       3322     3322           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Atomic Mass
===========
Denoted as: atomic-mass
Calculated from: atomic-data, selected-atoms
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these relationships are already present in the code and should be used to generate this.

@andrewfullard
Copy link
Contributor

I know this is WIP but something is better than nothing. Might be worth merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants