Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for reference data in tests workflow #2055

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Jun 14, 2022

📝 Description

Type: 🚀 feature | 🎢 infrastructure

  • Addresses issues of the download_reference_data.sh script:
    • Do not allow unbound variables (e.g. GITHUB_WORKSPACE)
    • Allow downloading different versions of reference data based on commit SHA. If REFDATA_SHA is blank, proceed to download the latest commit from master.

📌 Resources

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

Locally, set GITHUB_WORKSPACE="/path/to/folder" and REFDATA_SHA="" (o use a commit SHA instead)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #2055 (4d46ba5) into master (6cf502f) will not change coverage.
The diff coverage is n/a.

❗ Current head 4d46ba5 differs from pull request most recent head da8d2c1. Consider uploading reports for the commit da8d2c1 to get more accurate results

@@           Coverage Diff           @@
##           master    #2055   +/-   ##
=======================================
  Coverage   71.88%   71.88%           
=======================================
  Files         133      133           
  Lines       12386    12386           
=======================================
  Hits         8904     8904           
  Misses       3482     3482           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@epassaro epassaro changed the title Improvements for reference data downloader script Improvements for reference data in tests workflow Jun 14, 2022
@epassaro epassaro self-assigned this Mar 15, 2023
@epassaro epassaro closed this Apr 4, 2023
@epassaro epassaro reopened this Apr 4, 2023
@epassaro epassaro mentioned this pull request Apr 12, 2023
6 tasks
@andrewfullard
Copy link
Contributor

Is this still useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants