Sourcing Instancer primvars #250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedoardo
requested review from
bareya,
boberfly,
sergeneren and
skwerner
as code owners
|
I think we should skip creating an instance group if there are no primvars to be sourced. |
|
@dedoardo after I am done with building houdini artifacts I am going to have a look into this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch forward primvars authored on a point instancer to a additional set of attributes which takes precedence over the geometry's attribute set and can be indexed by each object.
So far we are only forwarding attributes with per-instance interpolation as HdInterpolationInstance seems to be the only one available. Since the core patch supports any interpolation, is it possible to extract primvars with different interpolation from the instancer in Hydra? If I am reading correctly, the USD documentation for point instancer mentions that it's possible for primvars to have different interpolation.
It is the glue code for this coreBlackbird PR
Changes
Todo
Doing the same thing for volumes is straightforward, but I am investigating primvar overrides to figure out if they should go through an InstanceGroup.